Skip to content

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Nov 4, 2019

ant-design/ant-design#19169

直接升级没发现什么问题,顺手改造到 father。

  • 升级 rc-trigger 4.0
  • 去掉 prop-types
  • 去掉 findDOMNode
  • 迁移到 father

@vercel
Copy link

vercel bot commented Nov 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/time-picker/gad1iaty2
🌍 Preview: https://time-picker-git-upgrade-rc-trigger.react-component.now.sh

@afc163 afc163 requested a review from zombieJ November 4, 2019 12:45
@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2019

This pull request introduces 1 alert when merging 59e4614 into e77b310 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #170 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage    92.2%   92.08%   -0.13%     
==========================================
  Files           7        6       -1     
  Lines         385      379       -6     
  Branches       98       99       +1     
==========================================
- Hits          355      349       -6     
  Misses         30       30
Impacted Files Coverage Δ
src/Panel.jsx 91.52% <ø> (-1.7%) ⬇️
src/Header.jsx 89.61% <ø> (-0.27%) ⬇️
src/Combobox.jsx 93.58% <ø> (-0.17%) ⬇️
src/TimePicker.jsx 94.11% <100%> (-0.17%) ⬇️
src/Select.jsx 90% <100%> (+0.34%) ⬆️
src/index.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77b310...5b4d6b9. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2019

This pull request introduces 1 alert when merging 49992e8 into e77b310 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@afc163 afc163 force-pushed the upgrade-rc-trigger branch from 64f4acb to 5b4d6b9 Compare November 4, 2019 13:05
@zombieJ zombieJ merged commit d708d84 into master Nov 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-rc-trigger branch November 6, 2019 02:14
@zombieJ
Copy link
Member

zombieJ commented Nov 6, 2019

+ [email protected] Pls help to check on antd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants