feat(tabs): Always callback setSelected. (#195)

BREAKING CHANGE: The `onSelect` callback will now also be called when clicking on the currently active tab.

Author: exabugs

dist/react-tabs.js

@@ -46,8 +46,6 @@ export default class UncontrolledTabs extends Component {
   tabNodes = [];
 
   setSelected(index, event) {
-    // Don't do anything if nothing has changed
-    if (index === this.props.selectedIndex) return;
     // Check index boundary
     if (index < 0 || index >= this.getTabsCount()) return;
 

dist/react-tabs.js.map

@@ -394,6 +394,40 @@ describe('<Tabs />', () => {
     assertTabSelected(wrapper, 0);
   });
 
+  test('should trigger onSelect handler when clicking', () => {
+    let wasClicked = false;
+    const wrapper = mount(
+      createTabs({
+        onSelect: () => {
+          wasClicked = true;
+        },
+      }),
+    );
+
+    assertTabSelected(wrapper, 0);
+
+    wrapper.childAt(0).childAt(1).simulate('click');
+    assertTabSelected(wrapper, 1);
+    expect(wasClicked).toBe(true);
+  });
+
+  test('should trigger onSelect handler when clicking on open tab', () => {
+    let wasClicked = false;
+    const wrapper = mount(
+      createTabs({
+        onSelect: () => {
+          wasClicked = true;
+        },
+      }),
+    );
+
+    assertTabSelected(wrapper, 0);
+
+    wrapper.childAt(0).childAt(0).simulate('click');
+    assertTabSelected(wrapper, 0);
+    expect(wasClicked).toBe(true);
+  });
+
   test('should switch tabs if setState is called within onSelect', () => {
     class Wrap extends React.Component {
       handleSelect = () => this.setState({ foo: 'bar' });