-
Notifications
You must be signed in to change notification settings - Fork 22
Font-size/zoom issues on iPadOS (desktop-class) + Firefox #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
More on Firefox: When applying one of our font-family, Edit: switched to revert in latest develop version (beta-9) as it hasn’t proved problematic. |
Firefox should be fixed in Will create a test case and open a bug report for this cos’ it’s quite uncomfortable having this tied entirely to the unit we are using. Safari iPadOS + desktop website is a whole other issue though, cos the implementation of the zoom intervention is so fundamentally broken the most reliable way to handle it is having the mobile website requested. I’ve had to do a lot of testing and debugging to isolate all the issues to solve in the first place, then find if they are solvable. The fun part being these interventions for desktop-class experience are not part of Webkit per se, they are Apple 100%, so even if reporting that in their bug tracker, I’m not sure it will be addressed. |
OK so Safari iOS with desktop-class experience can in theory be resolved using the combination of:
The major issue is that the value for Once again for some reason font-family seems to throw sand in the gears, which is why I can attempt to create a patch for iPadOS + desktop cos it makes me very uncomfortable to add that into the font-size user setting submodule tbh. But that has the potential to become high effort high maintenance in the longer term. |
Interestingly enough, normalizing text makes it work as expected so it seems Safari on iPadOS is struggling with font properties here (font-style, font-weight, font-variant…) Currently in the process of writing a patch, using |
Uh oh!
There was an error while loading. Please reload this page.
So this was supposed to be resolved through #155 but it looks like things have broken in nasty ways ever since.
We have two major issues with the new implementation of font-size (relying on
zoom
):-webkit-text-size-adjust: none
seems to not disable iPadOS desktop-class interventions reliably any longer;Firefox
implementation seems to really struggle inheriting zoom when there is a wrapping div/section, and has some nasty bugs on top of it.From testing and debugging from the problematic files on Readium Playground.
Moby Dick:
zoom: inherit
onbody > section
is needed to make it work, as well as disabling thefont-family
in… a Media Query (WTH)body
and from the Media Query forp
that works as expected withoutinheriting
font-family
in the Media Query as wellLes diaboliques:
zoom: inherit
onbody > div
seems to be fixing at least most of the issuesbody
that works as expected withoutinheriting
i
,span
, etc. must havezoom: value
set directly. Disabling the publisher font-family doesn’t seem to have any positive effect.It makes things quite possibly impossible to handle from ReadiumCSS, since adding
zoom:inherit
is basically like applying it twice in the cascade for other browsers. Same when setting it on elements.The text was updated successfully, but these errors were encountered: