Skip to content

This version of gosu is bringing cves #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dogruis opened this issue Nov 21, 2024 · 13 comments
Open

This version of gosu is bringing cves #424

dogruis opened this issue Nov 21, 2024 · 13 comments
Assignees

Comments

@dogruis
Copy link

dogruis commented Nov 21, 2024

ENV GOSU_VERSION 1.17

tianon/gosu#151
I created an issue to fix the cve errors

linked to redis/redis#13663

After reading this thread I am convinced that gosu shouldn't be used at all. As the lib hasn't had a release in more than a year and the lib owner refuses to bump the golang version anytime soon to 1.23.
tianon/gosu#136

@dogruis
Copy link
Author

dogruis commented Dec 2, 2024

Just for the update the owner of the lib is refusing to update his library to fix CVEs as stated in his readme.
I understand there is false positives but still maintaining libraries should be a thing.
tianon/gosu#136

@charles-horel-rogers
Copy link

@dogruis is there a plan to remove gosu? Or will these vulns remain present in the image

@dogruis
Copy link
Author

dogruis commented Feb 24, 2025

I am not part of the redis team and I requested something to be done. Tbh I would not use gosu as there is command line alternatives.

@frankyjquintero
Copy link

@oranagra @sundb @enjoy-binbin tenemos alguna novedad

Image

@dmaier-redislabs
Copy link
Contributor

dmaier-redislabs commented Mar 17, 2025

Hi @frankyjquintero,

from what I see, I would categorize this as a false-positive, but we will take a deeper look. @adamiBs FYI.

@tianon Could you please confirm the following:

  1. You are addressing CVE-s related to Go that are related to interfaces that impact gosu. Because there might be security issues in Go that are irrelevant to gosu, Docker Hub's CVE reporting might include false-positives. So it reports a CVE in Go that has no impact on gosu or the Docker containers that use gosuin the entrypoint script. Is this understanding correct?
  2. The command gosu is used to runredis-server under the user redis if no --user flag is specified when starting the container. This seems to be a safeguard mechanism to avoid running the process under root within the container. You can still restrict it more by running the container via docker run --user redis redis.

Regards,
David

@tianon
Copy link
Contributor

tianon commented Mar 17, 2025

Yes, that is correct (on both counts).

@adamiBs adamiBs self-assigned this Mar 26, 2025
@adamiBs
Copy link
Collaborator

adamiBs commented Mar 26, 2025

@Peter-Sh Resolves this in an upcoming release: #435

@adamiBs adamiBs marked this as a duplicate of #390 Mar 26, 2025
@adamiBs adamiBs marked this as a duplicate of #401 Mar 26, 2025
@adamiBs adamiBs marked this as a duplicate of #431 Mar 26, 2025
@adamiBs adamiBs marked this as a duplicate of #416 Mar 26, 2025
@adamiBs
Copy link
Collaborator

adamiBs commented Apr 14, 2025

@dogruis
Copy link
Author

dogruis commented Apr 14, 2025

Great but when is this release coming! it's been many many months and still no new tag? You already had a fix months ago what we are asking is a new tag containing the fixes

@adamiBs
Copy link
Collaborator

adamiBs commented Apr 15, 2025

The link I sent is a docker tag that contains this fix. @dogruis

@dogruis
Copy link
Author

dogruis commented Apr 15, 2025

Not really, it's a release candidate and not a release. So I would wait for a new release instead. Thanks a lot!!!!!

@LiorKogan
Copy link
Member

We are very close to the 8.0 GA release.
Sorry, but we cannot share the exact date.

@rayhsieh
Copy link

rayhsieh commented May 2, 2025

Will this fix be merged into redis 6 and redis 7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants