-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: reduxjs/react-redux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.0-beta.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: reduxjs/react-redux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.0-beta.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 9 files changed
- 4 contributors
Commits on Dec 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4dc875e - Browse repository at this point
Copy the full SHA 4dc875eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e5709 - Browse repository at this point
Copy the full SHA 45e5709View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1f2bd7 - Browse repository at this point
Copy the full SHA e1f2bd7View commit details
Commits on Dec 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for df40769 - Browse repository at this point
Copy the full SHA df40769View commit details
Commits on Jan 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e18feeb - Browse repository at this point
Copy the full SHA e18feebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 422c869 - Browse repository at this point
Copy the full SHA 422c869View commit details
Commits on Jan 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 87c5621 - Browse repository at this point
Copy the full SHA 87c5621View commit details
Commits on Feb 5, 2022
-
Switch back to Subscription in useSelector to fix unsubscribe perf
The Subscription impl originally used an array of listeners just like the actual Redux store, but in #1523 we changed it to be a linked list to fix perf issues. The use of `indexOf+splice` caused a quadratic cost to unmounting many components. In v8, I originally dropped use of `Subscription` to potentially save on bundle size. However, `Provider` still uses `Subscription`, so that will always be in the bundle. For this issue, a user pointed out that directly subscribing to the store brought back the original quadratic unsubscription behavior, which I've confirmed locally. Swapping `store.subscribe` for `subscription.addNestedSub` fixes that issue. I've added a unit test that mounts and unmounts a massive tree and measures the elapsed time. There's a distinct difference between the "correct" and quadratic behavior. Weirdly, there's also a big diff in "correct" time between React 18, and 17 + the "compat" entry point, and I have no idea why. It's not as bad as the quadratic time, but it's still pretty expensive. I've written the test to set an acceptable max unmount time based on which React version we're running against, with some buffer added.
Configuration menu - View commit details
-
Copy full SHA for 43d1cc6 - Browse repository at this point
Copy the full SHA 43d1cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30e8b4 - Browse repository at this point
Copy the full SHA a30e8b4View commit details
Commits on Feb 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 921b440 - Browse repository at this point
Copy the full SHA 921b440View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e18eae - Browse repository at this point
Copy the full SHA 2e18eaeView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.0.0-beta.2...v8.0.0-beta.3