fix: Swap writer and reader schema to correct places in sample (googleapis#1849)

kamalaboulhosn · gcf-owl-bot[bot] · web-flow · commit 1c79ad7336f5 · 2023-12-19T14:53:28.000-05:00
* samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add back in working asserts * Formatting fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Version/delete fixes * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * Add back in working asserts * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Formatting fixes * Version/delete fixes * samples: Schema evolution (googleapis#1499) * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add back in working asserts * Formatting fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Version/delete fixes * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * Add back in working asserts * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Formatting fixes * Version/delete fixes --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * Minor fixes for comments * samples: Schema evolution (googleapis#1499) * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add back in working asserts * Formatting fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Version/delete fixes * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * Add back in working asserts * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Formatting fixes * Version/delete fixes --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * Fix rollback example * Formatting * Formatting and wording fixes * Add new schemas to test directory * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Samples: Fix exception handling * fix: Set x-goog-request-params for streaming pull request * Revert "fix: Set x-goog-request-params for streaming pull request" This reverts commit 3185a3e. * Revert "Revert "fix: Set x-goog-request-params for streaming pull request"" This reverts commit 3b1f4d9. * Thread example * Add examples for limited and unlimited exeuctors * Add back missing semicolon * Revert changes to original async example * Revert changes to original async example * Add examples of different threading models * Make variables final to conform to style. * Fix catches * Fix ids * Fix naming * Revert "Merge pull request googleapis#2 from kamalaboulhosn/ML_experiments" This reverts commit 5a435fa, reversing changes made to c3a5725. * Set blunderbuss config to auto-assign issues and PRs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Swap writer and reader schema to correct places in sample * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
diff --git a/samples/snippets/src/main/java/pubsub/SubscribeWithAvroSchemaRevisionsExample.java b/samples/snippets/src/main/java/pubsub/SubscribeWithAvroSchemaRevisionsExample.java
@@ -93,7 +93,7 @@ public static void subscribeWithAvroSchemaRevisionsExample(
               Schema schema = schemaServiceClient.getSchema(name + "@" + revision);
               org.apache.avro.Schema avroSchema =
                   new org.apache.avro.Schema.Parser().parse(schema.getDefinition());
-              reader = new SpecificDatumReader<State>(State.getClassSchema(), avroSchema);
+              reader = new SpecificDatumReader<State>(avroSchema, State.getClassSchema());
               synchronized (revisionReaders) {
                 revisionReaders.put(revision, reader);
               }

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public static void subscribeWithAvroSchemaRevisionsExample(`
`93`	`93`	`Schema schema = schemaServiceClient.getSchema(name + "@" + revision);`
`94`	`94`	`org.apache.avro.Schema avroSchema =`
`95`	`95`	`new org.apache.avro.Schema.Parser().parse(schema.getDefinition());`
`96`		`- reader = new SpecificDatumReader<State>(State.getClassSchema(), avroSchema);`
	`96`	`+ reader = new SpecificDatumReader<State>(avroSchema, State.getClassSchema());`
`97`	`97`	`synchronized (revisionReaders) {`
`98`	`98`	`revisionReaders.put(revision, reader);`
`99`	`99`	`}`