Skip to content

Commit 48deed1

Browse files
committed
MERGE PREP: Renamed "Fluent" to "Transformed"
...to align with branch "redesign2".
1 parent babd4b4 commit 48deed1

19 files changed

+199
-200
lines changed

src/main/java/crud/pattern/ResourceMerger.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
import crud.core.ReadableResource;
1818
import crud.core.Resource;
1919
import crud.core.WritableResource;
20-
import crud.transform.FluentReadableResource;
21-
import crud.transform.FluentWritableResource;
20+
import crud.transform.TransformedReadableResource;
21+
import crud.transform.TransformedWritableResource;
2222
import rx.Observable;
2323
import rx.functions.Func0;
2424
import rx.functions.Func1;
@@ -37,7 +37,7 @@
3737
* back.
3838
*
3939
* This class is provided as an alternative to flatMap operations on the
40-
* {@link FluentReadableResource} and {@link FluentWritableResource} types.
40+
* {@link TransformedReadableResource} and {@link TransformedWritableResource} types.
4141
* In contrast to those hypothetical operations, this class makes explicit the
4242
* relationship between reading and writing, and encapsulates any side effects
4343
* in the caller-provided function.
@@ -55,7 +55,7 @@ public abstract class ResourceMerger<RESPONSE> {
5555
public static <RSRC, RESPONSE> ResourceMerger<RESPONSE> withWriter(
5656
final ReadableResource<RSRC> reader,
5757
final WritableResource<RSRC, RESPONSE> writer) {
58-
return new MergerImpl<>(reader, FluentWritableResource.from(writer).toFunction());
58+
return new MergerImpl<>(reader, TransformedWritableResource.from(writer).toFunction());
5959
}
6060

6161
/**
@@ -68,8 +68,8 @@ public static <RRSRC, WRSRC, RESPONSE> ResourceMerger<RESPONSE> mapToWriter(
6868
final Func1<? super Observable<RRSRC>, ? extends Observable<WRSRC>> mapper,
6969
final WritableResource<WRSRC, RESPONSE> writer) {
7070
return new MergerImpl<>(
71-
FluentReadableResource.from(reader).mapValue(mapper),
72-
FluentWritableResource.from(writer).toFunction());
71+
TransformedReadableResource.from(reader).mapValue(mapper),
72+
TransformedWritableResource.from(writer).toFunction());
7373
}
7474

7575
/**
@@ -106,7 +106,7 @@ private ResourceMerger() {
106106
* reflected in the public API.
107107
*/
108108
private static final class MergerImpl<RSRC, RESPONSE> extends ResourceMerger<RESPONSE> {
109-
private final FluentReadableResource<RESPONSE> merger;
109+
private final TransformedReadableResource<RESPONSE> merger;
110110
/**
111111
* Kept around just for {@link #toString()}, {@link #equals(Object)},
112112
* and {@link #hashCode()}. The results of the former and latter could
@@ -121,7 +121,7 @@ private static final class MergerImpl<RSRC, RESPONSE> extends ResourceMerger<RES
121121
public MergerImpl(
122122
final ReadableResource<RSRC> reader,
123123
final Func1<RSRC, ? extends Observable<? extends RESPONSE>> writer) {
124-
this.merger = FluentReadableResource.from(reader).mapValue(new Func1<Observable<RSRC>, Observable<RESPONSE>>() {
124+
this.merger = TransformedReadableResource.from(reader).mapValue(new Func1<Observable<RSRC>, Observable<RESPONSE>>() {
125125
@Override
126126
public Observable<RESPONSE> call(final Observable<RSRC> resource) {
127127
return resource.flatMap(writer);

src/main/java/crud/transform/FluentReadableResource.java renamed to src/main/java/crud/transform/TransformedReadableResource.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424

2525

2626
/**
27-
* A set of fluent transformations on {@link ReadableResource}s.
27+
* A set of transformations on {@link ReadableResource}s.
2828
*/
29-
public abstract class FluentReadableResource<RSRC> implements ReadableResource<RSRC> {
29+
public abstract class TransformedReadableResource<RSRC> implements ReadableResource<RSRC> {
3030

3131
/**
32-
* If the given resource is a {@code FluentReadableResource}, return it.
32+
* If the given resource is a {@code TransformedReadableResource}, return it.
3333
* Otherwise, wrap it in a new instance.
3434
*/
35-
public static <RSRC> FluentReadableResource<RSRC> from(final ReadableResource<RSRC> resource) {
36-
if (resource instanceof FluentReadableResource<?>) {
37-
return (FluentReadableResource<RSRC>) resource;
35+
public static <RSRC> TransformedReadableResource<RSRC> from(final ReadableResource<RSRC> resource) {
36+
if (resource instanceof TransformedReadableResource<?>) {
37+
return (TransformedReadableResource<RSRC>) resource;
3838
} else {
3939
return new DelegatingReadableResource<>(resource);
4040
}
@@ -44,13 +44,13 @@ public static <RSRC> FluentReadableResource<RSRC> from(final ReadableResource<RS
4444
* Create and return a new resource that will transform the state of
4545
* this resource.
4646
*
47-
* If this method is called on two equal {@code FluentReadableResource}s,
47+
* If this method is called on two equal {@code TransformedReadableResource}s,
4848
* the results will be equal if the functions are equal. If equality
4949
* behavior it important to you (for example, if you intend to keep
5050
* resources in a {@code HashSet}), consider it in your function
5151
* implementation.
5252
*/
53-
public <TO> FluentReadableResource<TO> mapValue(
53+
public <TO> TransformedReadableResource<TO> mapValue(
5454
final Func1<? super Observable<RSRC>, ? extends Observable<TO>> mapper) {
5555
return new MappingReadableResource<>(this, mapper);
5656
}
@@ -79,7 +79,7 @@ private DelegateObjectMethods.Callable<Observable<RSRC>> toResourceCallable() {
7979
return new DelegateObjectMethods.Callable<Observable<RSRC>>(this) {
8080
@Override
8181
public Observable<RSRC> call() {
82-
return FluentReadableResource.this.read();
82+
return TransformedReadableResource.this.read();
8383
}
8484
};
8585
}
@@ -90,14 +90,14 @@ public Observable<RSRC> call() {
9090
* combined with its parent class, because it needs additional type
9191
* parameters that should not be public.
9292
*/
93-
private static abstract class AbstractFluentReadableResource<FROM, TO, T>
94-
extends FluentReadableResource<TO> {
95-
protected final FluentResourceStateMixin<ReadableResource<FROM>, T> state;
93+
private static abstract class AbstractTransformedReadableResource<FROM, TO, T>
94+
extends TransformedReadableResource<TO> {
95+
protected final TransformedResourceStateMixin<ReadableResource<FROM>, T> state;
9696

97-
protected AbstractFluentReadableResource(
97+
protected AbstractTransformedReadableResource(
9898
final ReadableResource<FROM> delegate,
9999
final T auxiliary) {
100-
this.state = new FluentResourceStateMixin<>(delegate, auxiliary);
100+
this.state = new TransformedResourceStateMixin<>(delegate, auxiliary);
101101
}
102102

103103
@Override
@@ -111,7 +111,7 @@ public boolean equals(final Object obj) {
111111
if (getClass() != obj.getClass()) {
112112
return false;
113113
}
114-
final AbstractFluentReadableResource<?, ?, ?> other = (AbstractFluentReadableResource<?, ?, ?>) obj;
114+
final AbstractTransformedReadableResource<?, ?, ?> other = (AbstractTransformedReadableResource<?, ?, ?>) obj;
115115
return this.state.equals(other.state);
116116
}
117117

@@ -124,11 +124,11 @@ public int hashCode() {
124124

125125
/**
126126
* It may seem that the business of this class could be accomplished by
127-
* FluentReadableResource itself. However, that would require an
127+
* TransformedReadableResource itself. However, that would require an
128128
* additional layer of equals() and hashCode overrides and an unsafe cast.
129129
*/
130130
private static final class DelegatingReadableResource<RSRC>
131-
extends AbstractFluentReadableResource<RSRC, RSRC, Void> {
131+
extends AbstractTransformedReadableResource<RSRC, RSRC, Void> {
132132
public DelegatingReadableResource(final ReadableResource<RSRC> delegate) {
133133
super(delegate, null);
134134
}
@@ -143,7 +143,7 @@ public Observable<RSRC> read() {
143143

144144

145145
private static final class MappingReadableResource<FROM, TO>
146-
extends AbstractFluentReadableResource<FROM, TO, Func1<? super Observable<FROM>, ? extends Observable<TO>>> {
146+
extends AbstractTransformedReadableResource<FROM, TO, Func1<? super Observable<FROM>, ? extends Observable<TO>>> {
147147
public MappingReadableResource(
148148
final ReadableResource<FROM> delegate,
149149
final Func1<? super Observable<FROM>, ? extends Observable<TO>> mapper) {

src/main/java/crud/transform/FluentReadableResourceSet.java renamed to src/main/java/crud/transform/TransformedReadableResourceSet.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,29 +21,29 @@
2121
import rx.functions.Func1;
2222

2323

24-
public abstract class FluentReadableResourceSet<KEY, RSRC>
24+
public abstract class TransformedReadableResourceSet<KEY, RSRC>
2525
implements ReadableResourceSet<KEY, RSRC> {
2626

27-
public static <KEY, RSRC> FluentReadableResourceSet<KEY, RSRC> from(
27+
public static <KEY, RSRC> TransformedReadableResourceSet<KEY, RSRC> from(
2828
final ReadableResourceSet<KEY, RSRC> rsrcSet) {
29-
if (rsrcSet instanceof FluentReadableResourceSet<?, ?>) {
30-
return (FluentReadableResourceSet<KEY, RSRC>) rsrcSet;
29+
if (rsrcSet instanceof TransformedReadableResourceSet<?, ?>) {
30+
return (TransformedReadableResourceSet<KEY, RSRC>) rsrcSet;
3131
} else {
32-
return new FluentReadableResourceSet<KEY, RSRC>() {
32+
return new TransformedReadableResourceSet<KEY, RSRC>() {
3333
@Override
34-
public FluentReadableResource<RSRC> get(final KEY key) {
35-
return FluentReadableResource.from(rsrcSet.get(key));
34+
public TransformedReadableResource<RSRC> get(final KEY key) {
35+
return TransformedReadableResource.from(rsrcSet.get(key));
3636
}
3737
};
3838
}
3939
}
4040

41-
public <R> FluentReadableResourceSet<KEY, R> mapValue(
41+
public <R> TransformedReadableResourceSet<KEY, R> mapValue(
4242
final Func1<? super Observable<? super RSRC>, ? extends Observable<R>> mapper) {
4343
Objects.requireNonNull(mapper, "null function");
44-
final FluentReadableResourceSet<KEY, R> result = new FluentReadableResourceSet<KEY, R>() {
44+
final TransformedReadableResourceSet<KEY, R> result = new TransformedReadableResourceSet<KEY, R>() {
4545
@Override
46-
public FluentReadableResource<R> get(final KEY key) {
46+
public TransformedReadableResource<R> get(final KEY key) {
4747
return outerResourceSet()
4848
.get(key)
4949
.mapValue(mapper);
@@ -52,12 +52,12 @@ public FluentReadableResource<R> get(final KEY key) {
5252
return result;
5353
}
5454

55-
public <K> FluentReadableResourceSet<K, RSRC> adaptKey(
55+
public <K> TransformedReadableResourceSet<K, RSRC> adaptKey(
5656
final Func1<? super K, ? extends KEY> adapter) {
5757
Objects.requireNonNull(adapter, "null function");
58-
final FluentReadableResourceSet<K, RSRC> result = new FluentReadableResourceSet<K, RSRC>() {
58+
final TransformedReadableResourceSet<K, RSRC> result = new TransformedReadableResourceSet<K, RSRC>() {
5959
@Override
60-
public FluentReadableResource<RSRC> get(final K key) {
60+
public TransformedReadableResource<RSRC> get(final K key) {
6161
Objects.requireNonNull(key, "null key");
6262
final KEY transformedKey = adapter.call(key);
6363
return outerResourceSet().get(transformedKey);
@@ -66,19 +66,19 @@ public FluentReadableResource<RSRC> get(final K key) {
6666
return result;
6767
}
6868

69-
public Func1<KEY, FluentReadableResource<RSRC>> toFunction() {
70-
return new DelegateObjectMethods.Function<KEY, FluentReadableResource<RSRC>>(this) {
69+
public Func1<KEY, TransformedReadableResource<RSRC>> toFunction() {
70+
return new DelegateObjectMethods.Function<KEY, TransformedReadableResource<RSRC>>(this) {
7171
@Override
72-
public FluentReadableResource<RSRC> call(final KEY key) {
72+
public TransformedReadableResource<RSRC> call(final KEY key) {
7373
return get(key);
7474
}
7575
};
7676
}
7777

7878
@Override
79-
public abstract FluentReadableResource<RSRC> get(KEY key);
79+
public abstract TransformedReadableResource<RSRC> get(KEY key);
8080

81-
private FluentReadableResourceSet<KEY, RSRC> outerResourceSet() {
81+
private TransformedReadableResourceSet<KEY, RSRC> outerResourceSet() {
8282
return this;
8383
}
8484

src/main/java/crud/transform/FluentResourceStateMixin.java renamed to src/main/java/crud/transform/TransformedResourceStateMixin.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,14 @@
1717
import java.util.Objects;
1818

1919
import crud.core.Resource;
20-
2120
import rx.functions.Func1;
2221

2322

2423
/**
25-
* Maintains state on behalf of the {@code Fluent*Resource} classes in this
24+
* Maintains state on behalf of the {@code Transformed*Resource} classes in this
2625
* package, in order to minimize repeated boilerplate code.
2726
*/
28-
/*package*/ final class FluentResourceStateMixin<R extends Resource, T> {
27+
/*package*/ final class TransformedResourceStateMixin<R extends Resource, T> {
2928

3029
private final R delegate;
3130
private final T auxiliaryState;
@@ -39,7 +38,7 @@
3938
* {@link Func1} -- specific to the concrete type of the
4039
* wrapping {@code Resource}. It may be null.
4140
*/
42-
public FluentResourceStateMixin(final R delegate, final T auxiliary) {
41+
public TransformedResourceStateMixin(final R delegate, final T auxiliary) {
4342
this.delegate = Objects.requireNonNull(delegate);
4443
this.auxiliaryState = auxiliary; // may be null
4544
}
@@ -63,7 +62,7 @@ public boolean equals(final Object obj) {
6362
if (getClass() != obj.getClass()) {
6463
return false;
6564
}
66-
final FluentResourceStateMixin<?, ?> other = (FluentResourceStateMixin<?, ?>) obj;
65+
final TransformedResourceStateMixin<?, ?> other = (TransformedResourceStateMixin<?, ?>) obj;
6766
if (!this.delegate.equals(other.delegate)) {
6867
return false;
6968
}

src/main/java/crud/transform/FluentWritableResource.java renamed to src/main/java/crud/transform/TransformedWritableResource.java

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@
2222

2323

2424
/**
25-
* A set of fluent transformations on {@link WritableResource}s.
25+
* A set of transformations on {@link WritableResource}s.
2626
*/
27-
public abstract class FluentWritableResource<RSRC, RESPONSE> implements WritableResource<RSRC, RESPONSE> {
27+
public abstract class TransformedWritableResource<RSRC, RESPONSE> implements WritableResource<RSRC, RESPONSE> {
2828

2929
/**
30-
* If the given resource is a {@code FluentWritableResource}, return it.
30+
* If the given resource is a {@code TransformedWritableResource}, return it.
3131
* Otherwise, wrap it in a new instance.
3232
*/
33-
public static <RSRC, RESPONSE> FluentWritableResource<RSRC, RESPONSE> from(
33+
public static <RSRC, RESPONSE> TransformedWritableResource<RSRC, RESPONSE> from(
3434
final WritableResource<RSRC, RESPONSE> resource) {
35-
if (resource instanceof FluentWritableResource<?, ?>) {
36-
return (FluentWritableResource<RSRC, RESPONSE>) resource;
35+
if (resource instanceof TransformedWritableResource<?, ?>) {
36+
return (TransformedWritableResource<RSRC, RESPONSE>) resource;
3737
} else {
3838
return new DelegatingWritableResource<>(resource);
3939
}
@@ -43,13 +43,13 @@ public static <RSRC, RESPONSE> FluentWritableResource<RSRC, RESPONSE> from(
4343
* Create and return a new resource that will transform the responses from
4444
* this resource.
4545
*
46-
* If this method is called on two equal {@code FluentWritableResource}s,
46+
* If this method is called on two equal {@code TransformedWritableResource}s,
4747
* the results will be equal if the functions are equal. If equality
4848
* behavior it important to you (for example, if you intend to keep
4949
* resources in a {@code HashSet}), consider it in your function
5050
* implementation.
5151
*/
52-
public <TO> FluentWritableResource<RSRC, TO> mapResponse(
52+
public <TO> TransformedWritableResource<RSRC, TO> mapResponse(
5353
final Func1<? super Observable<RESPONSE>, ? extends Observable<TO>> mapper) {
5454
return new MappingWritableResource<>(this, mapper);
5555
}
@@ -58,13 +58,13 @@ public <TO> FluentWritableResource<RSRC, TO> mapResponse(
5858
* Create and return a new resource that will transform the input resource
5959
* states before passing them to this resource.
6060
*
61-
* If this method is called on two equal {@code FluentWritableResource}s,
61+
* If this method is called on two equal {@code TransformedWritableResource}s,
6262
* the results will be equal if the functions are equal. If equality
6363
* behavior it important to you (for example, if you intend to keep
6464
* resources in a {@code HashSet}), consider it in your function
6565
* implementation.
6666
*/
67-
public <TO> FluentWritableResource<TO, RESPONSE> adaptNewValue(
67+
public <TO> TransformedWritableResource<TO, RESPONSE> adaptNewValue(
6868
final Func1<? super TO, ? extends RSRC> adapter) {
6969
return new AdaptingWritableResource<>(this, adapter);
7070
}
@@ -79,7 +79,7 @@ public Func1<RSRC, Observable<RESPONSE>> toFunction() {
7979
return new DelegateObjectMethods.Function<RSRC, Observable<RESPONSE>>(this) {
8080
@Override
8181
public Observable<RESPONSE> call(final RSRC newValue) {
82-
return FluentWritableResource.this.write(newValue);
82+
return TransformedWritableResource.this.write(newValue);
8383
}
8484
};
8585
}
@@ -90,14 +90,14 @@ public Observable<RESPONSE> call(final RSRC newValue) {
9090
* combined with its parent class, because it needs additional type
9191
* parameters that should not be public.
9292
*/
93-
private static abstract class AbstractFluentWritableResource<FROMRS, TORS, FROMRP, TORP, T>
94-
extends FluentWritableResource<TORS, TORP> {
95-
protected final FluentResourceStateMixin<WritableResource<FROMRS, FROMRP>, T> state;
93+
private static abstract class AbstractTransformedWritableResource<FROMRS, TORS, FROMRP, TORP, T>
94+
extends TransformedWritableResource<TORS, TORP> {
95+
protected final TransformedResourceStateMixin<WritableResource<FROMRS, FROMRP>, T> state;
9696

97-
protected AbstractFluentWritableResource(
97+
protected AbstractTransformedWritableResource(
9898
final WritableResource<FROMRS, FROMRP> delegate,
9999
final T auxiliary) {
100-
this.state = new FluentResourceStateMixin<>(delegate, auxiliary);
100+
this.state = new TransformedResourceStateMixin<>(delegate, auxiliary);
101101
}
102102

103103
@Override
@@ -111,7 +111,7 @@ public boolean equals(final Object obj) {
111111
if (getClass() != obj.getClass()) {
112112
return false;
113113
}
114-
final AbstractFluentWritableResource<?, ?, ?, ?, ?> other = (AbstractFluentWritableResource<?, ?, ?, ?, ?>) obj;
114+
final AbstractTransformedWritableResource<?, ?, ?, ?, ?> other = (AbstractTransformedWritableResource<?, ?, ?, ?, ?>) obj;
115115
return this.state.equals(other.state);
116116
}
117117

@@ -123,7 +123,7 @@ public int hashCode() {
123123

124124

125125
private static final class DelegatingWritableResource<RSRC, RESPONSE>
126-
extends AbstractFluentWritableResource<RSRC, RSRC, RESPONSE, RESPONSE, Void> {
126+
extends AbstractTransformedWritableResource<RSRC, RSRC, RESPONSE, RESPONSE, Void> {
127127
public DelegatingWritableResource(final WritableResource<RSRC, RESPONSE> delegate) {
128128
super(delegate, null);
129129
}
@@ -138,7 +138,7 @@ public Observable<RESPONSE> write(final RSRC newValue) {
138138

139139

140140
private static final class MappingWritableResource<RSRC, FROM, TO>
141-
extends AbstractFluentWritableResource<RSRC, RSRC, FROM, TO, Func1<? super Observable<FROM>, ? extends Observable<TO>>> {
141+
extends AbstractTransformedWritableResource<RSRC, RSRC, FROM, TO, Func1<? super Observable<FROM>, ? extends Observable<TO>>> {
142142
public MappingWritableResource(
143143
final WritableResource<RSRC, FROM> delegate,
144144
final Func1<? super Observable<FROM>, ? extends Observable<TO>> mapper) {
@@ -156,7 +156,7 @@ public Observable<TO> write(final RSRC value) {
156156

157157

158158
private static final class AdaptingWritableResource<FROM, TO, RESPONSE>
159-
extends AbstractFluentWritableResource<FROM, TO, RESPONSE, RESPONSE, Func1<? super TO, ? extends FROM>> {
159+
extends AbstractTransformedWritableResource<FROM, TO, RESPONSE, RESPONSE, Func1<? super TO, ? extends FROM>> {
160160
private AdaptingWritableResource(
161161
final WritableResource<FROM, RESPONSE> delegate,
162162
final Func1<? super TO, ? extends FROM> adapter) {

0 commit comments

Comments
 (0)