Improve req_set_exception_breakpoints helper

Author: st0012

CONTRIBUTING.md

@@ -316,9 +316,30 @@ Sends request to rdbg to add a breakpoint.
 
 Sends request to rdbg to delete a breakpoint.
 
-- req_set_exception_breakpoints
+- req_set_exception_breakpoints(breakpoints)
 
-Sends request to rdbg to set exception breakpoints.
+Sends request to rdbg to set exception breakpoints. e.g.
+
+```rb
+req_set_exception_breakpoints([{ name: "RuntimeError", condition: "a == 1" }])
+```
+
+Please note that `setExceptionBreakpoints` resets all exception breakpoints in every request. 
+
+So the following code will only set breakpoint for `Exception`.
+
+```rb
+req_set_exception_breakpoints([{ name: "RuntimeError" }])
+req_set_exception_breakpoints([{ name: "Exception" }])
+```
+
+This means you can also use
+
+```rb
+req_set_exception_breakpoints([])
+```
+
+to clear all exception breakpoints.
 
 - req_continue
 

test/protocol/catch_test.rb

@@ -13,32 +13,31 @@ class CatchTest < TestCase
      6| foo
     RUBY
 
-    def test_catch_stops_when_the_runtime_error_raised
+    def test_set_exception_breakpoints_sets_exception_breakpoints
       run_protocol_scenario PROGRAM do
-        req_set_exception_breakpoints
+        req_set_exception_breakpoints([{ name: "RuntimeError" }])
         req_continue
         assert_line_num 3
         req_terminate_debuggee
       end
     end
 
-    def test_set_exception_breakpoints_unset_exception_breakpoints
+    def test_set_exception_breakpoints_unsets_exception_breakpoints
       run_protocol_scenario PROGRAM, cdp: false do
-        req_set_exception_breakpoints
-        req_set_exception_breakpoints(exception: nil)
+        req_set_exception_breakpoints([{ name: "RuntimeError" }])
+        req_set_exception_breakpoints([])
         req_continue
       end
     end
 
     def test_set_exception_breakpoints_accepts_condition
       run_protocol_scenario PROGRAM, cdp: false do
-        req_set_exception_breakpoints(condition: "a == 2")
+        req_set_exception_breakpoints([{ name: "RuntimeError", condition: "a == 2" }])
         req_continue
-        # exits directly because of error
       end
 
       run_protocol_scenario PROGRAM, cdp: false do
-        req_set_exception_breakpoints(condition: "a == 1")
+        req_set_exception_breakpoints([{ name: "RuntimeError", condition: "a == 1" }])
         req_continue
         assert_line_num 3
         req_terminate_debuggee

test/support/protocol_utils.rb

@@ -125,15 +125,13 @@ def req_finish
       end
     end
 
-    def req_set_exception_breakpoints(exception: "RuntimeError", condition: nil)
+    def req_set_exception_breakpoints(breakpoints)
       case ENV['RUBY_DEBUG_TEST_UI']
       when 'vscode'
-        filter_options = []
-
-        if exception
-          filter_option = { filterId: exception }
-          filter_option[:condition] = condition if condition
-          filter_options << filter_option
+        filter_options = breakpoints.map do |bp|
+          filter_option = { filterId: bp[:name] }
+          filter_option[:condition] = bp[:condition] if bp[:condition]
+          filter_option
         end
 
         send_dap_request 'setExceptionBreakpoints', filters: [], filterOptions: filter_options