Fix formats in evaluation methods for protocol tests #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Mar 26, 2022
ono-max
force-pushed
the
patch-63
branch
3 times, most recently
from
371f9b9 to
904334c
Compare
|
@ono-max this probably deserves another PR, but can we also support checking error messages? like assert_hover_result({ error: "Not defined global variable: \"$bar\"" }, "$bar")currently the test would just fail if it received an error response, even though that's exactly what I want to test. an example would be, the debugger console skips a list of global vars but the servers don't. if we want to align servers' behavior with the console, we need to be able to test the error conditions to make sure those vars are skipped. |
|
Nice catch. We should support it, too. |
|
@ono-max I think this can be merged but there seems to be conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.