Make sure to fail when remote debuggee does not exit after scenarios #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
force-pushed
the
patch-156
branch
3 times, most recently
from
5efe82e to
d24b094
Compare
This was referenced Nov 21, 2022
Closed
Remote debuggee begin to exit when readable stream or writable stream is closed. Thus, tests do not fail even though remote debuggee does not exit after scenarios. We need to close streams after `kill_safely` method.
5 seconds is not enough time to wait. See https://github.com/ruby/debug/actions/runs/3514525114/jobs/5888644746#step:4:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote debuggee begin to exit when readable stream or writable stream is closed. Thus, tests do not fail even though remote debuggee does not exit after scenarios. We need to close streams after
kill_safelymethod.This needs #817.