net/imap: support NAMESPACE extension (RFC2342) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
NAMESPACE-extension-RFC2342
branch
from
07b5526 to
45845b4
Compare
This extension predates IMAP4rev1 (RFC3501), so most IMAP servers
support it. Many popular IMAP servers are configured with the default
personal namespaces as `("" "/")`: no prefix and "/" hierarchy
delimiter. In that common case, the naive client may not have any
trouble naming mailboxes.
But many servers are configured e.g. with the default personal namespace
as `("INBOX." ".")`, placing all personal folders under INBOX with "."
as the hierarchy delimiter. If the client does not check for this, but
naively assumes it can use the same folder names for all servers, then
folder creation (and listing, moving, etc) can lead to errors.
nevans
force-pushed
the
NAMESPACE-extension-RFC2342
branch
from
45845b4 to
8151f1a
Compare
Member
|
@nevans Thank you. I've merged it manually to resolve conflicts. |
Collaborator
Author
|
Thanks for handling those conflicts, @shugo. I was trying to keep the PRs small and self-contained to hopefully be easier to review, but there was a lot of overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension predates IMAP4rev1 (RFC3501), so most IMAP servers
support it. Many popular IMAP servers are configured with the default
personal namespaces as
("" "/"): no prefix and "/" hierarchydelimiter. In that common case, the naive client may not have any
trouble naming mailboxes.
But many servers are configured e.g. with the default personal namespace
as
("INBOX." "."), placing all personal folders under INBOX with "."as the hierarchy delimiter. If the client does not check for this, but
naively assumes it can use the same folder names for all servers, then
folder creation (and listing, moving, etc) can lead to errors.
n.b. I submitted this PR previously, before net-imap was gemified: