chore: review comments

Author: atzoum

processor/internal/transformer/destination_transformer/destination_transformer.go

@@ -229,7 +229,7 @@ func (d *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
 		return nil, nil
 	}
 	start := time.Now()
-	compactRequestPayloads := d.compactRequestPayloads() // consistent state for the entire request
+	compactRequestPayloads := d.config.compactionSupported // consistent state for the entire request
 	// Call remote transformation
 	rawJSON, err := d.getRequestPayload(data, compactRequestPayloads)
 	if err != nil {
@@ -431,10 +431,6 @@ func (c *Client) canRunWarehouseTransformations(destType string) bool {
 	return false
 }
 
-func (d *Client) compactRequestPayloads() bool {
-	return (d.config.compactionSupported)
-}
-
 func (d *Client) getRequestPayload(data []types.TransformerEvent, compactRequestPayloads bool) ([]byte, error) {
 	if compactRequestPayloads {
 		ctr := types.CompactedTransformRequest{

router/transformer/transformer.go

@@ -167,7 +167,7 @@ func (trans *handle) Transform(transformType string, transformMessage *types.Tra
 	start := time.Now()
 	var destinationJobs types.DestinationJobs
 	transformMessageCopy, preservedData := transformMessage.Dehydrate()
-	compactRequestPayloads := trans.compactRequestPayloads() // consistent state for the entire request
+	compactRequestPayloads := trans.compactionSupported // consistent state for the entire request
 
 	rawJSON, err := trans.getRequestPayload(transformMessageCopy, compactRequestPayloads)
 	if err != nil {
@@ -785,10 +785,6 @@ func getEndpointFromURL(urlStr string) string {
 	return ""
 }
 
-func (trans *handle) compactRequestPayloads() bool {
-	return (trans.compactionSupported)
-}
-
 func (trans *handle) getRequestPayload(data *types.TransformMessageT, compactRequestPayloads bool) ([]byte, error) {
 	if compactRequestPayloads {
 		return jsonrs.Marshal(data.Compacted())

router/transformer/transformer_test.go

@@ -2064,20 +2064,3 @@ func TestTransformerMetrics(t *testing.T) {
 		}
 	}
 }
-
-func TestTransformerCompactionFlags(t *testing.T) {
-	t.Run("compaction not supported", func(t *testing.T) {
-		h := &handle{
-			compactionSupported: false,
-		}
-
-		require.False(t, h.compactRequestPayloads())
-	})
-
-	t.Run("compaction supported ", func(t *testing.T) {
-		h := &handle{
-			compactionSupported: true,
-		}
-		require.True(t, h.compactRequestPayloads())
-	})
-}