chore: clean up logs to trace double-encoded HLL value issue (#6310)

Reverts #6044

Author: itsmihir

enterprise/reporting/flusher/aggregator/tracked_users_inapp.go

@@ -12,25 +12,21 @@ import (
 
 	"github.com/rudderlabs/rudder-go-kit/config"
 	"github.com/rudderlabs/rudder-go-kit/jsonrs"
-	"github.com/rudderlabs/rudder-go-kit/logger"
 	"github.com/rudderlabs/rudder-go-kit/stats"
 )
 
 const tableName = `tracked_users_reports`
 
-const problematicHLLValue = "5c78313139303766"
-
 type TrackedUsersInAppAggregator struct {
-	db     *sql.DB
-	stats  stats.Stats
-	logger logger.Logger
+	db    *sql.DB
+	stats stats.Stats
 
 	reportsCounter    stats.Measurement
 	aggReportsCounter stats.Measurement
 }
 
-func NewTrackedUsersInAppAggregator(db *sql.DB, s stats.Stats, conf *config.Config, module string, logger logger.Logger) *TrackedUsersInAppAggregator {
-	t := TrackedUsersInAppAggregator{db: db, stats: s, logger: logger}
+func NewTrackedUsersInAppAggregator(db *sql.DB, s stats.Stats, conf *config.Config, module string) *TrackedUsersInAppAggregator {
+	t := TrackedUsersInAppAggregator{db: db, stats: s}
 	tags := stats.Tags{
 		"instance": conf.GetString("INSTANCE_ID", "1"),
 		"table":    tableName,
@@ -59,14 +55,6 @@ func (a *TrackedUsersInAppAggregator) Aggregate(ctx context.Context, start, end
 		if err != nil {
 			return nil, fmt.Errorf("cannot scan row %w", err)
 		}
-
-		if r.UserIDHLLHex == problematicHLLValue || r.AnonymousIDHLLHex == problematicHLLValue || r.IdentifiedAnonymousIDHLLHex == problematicHLLValue {
-			a.logger.Errorn("found problematic hll value from database",
-				logger.NewStringField("workspace_id", r.WorkspaceID),
-				logger.NewStringField("source_id", r.SourceID),
-			)
-		}
-
 		r.UserIDHLL, err = a.decodeHLL(r.UserIDHLLHex)
 		if err != nil {
 			return nil, fmt.Errorf("cannot decode hll %w", err)
@@ -97,7 +85,7 @@ func (a *TrackedUsersInAppAggregator) Aggregate(ctx context.Context, start, end
 		return nil, fmt.Errorf("rows errors %w", err)
 	}
 
-	jsonReports, err = marshalReports(aggReportsMap, a.logger)
+	jsonReports, err = marshalReports(aggReportsMap)
 	if err != nil {
 		return nil, fmt.Errorf("error marshalling reports %w", err)
 	}
@@ -120,21 +108,13 @@ func (a *TrackedUsersInAppAggregator) decodeHLL(encoded string) (*hll.Hll, error
 	return &hll, nil
 }
 
-func marshalReports(aggReportsMap map[string]*TrackedUsersReport, log logger.Logger) ([]json.RawMessage, error) {
+func marshalReports(aggReportsMap map[string]*TrackedUsersReport) ([]json.RawMessage, error) {
 	jsonReports := make([]json.RawMessage, 0, len(aggReportsMap))
 	for _, v := range aggReportsMap {
 		data, err := jsonrs.Marshal(v)
 		if err != nil {
 			return nil, err
 		}
-
-		if v.UserIDHLLHex == problematicHLLValue || v.AnonymousIDHLLHex == problematicHLLValue || v.IdentifiedAnonymousIDHLLHex == problematicHLLValue {
-			log.Errorn("found problematic hll value in marshalled data",
-				logger.NewStringField("workspace_id", v.WorkspaceID),
-				logger.NewStringField("source_id", v.SourceID),
-			)
-		}
-
 		jsonReports = append(jsonReports, data)
 	}
 	return jsonReports, nil

enterprise/reporting/flusher/factory.go

@@ -56,7 +56,7 @@ func CreateRunner(ctx context.Context, table string, log logger.Logger, stats st
 		parsedURL.Path = path.Join(parsedURL.Path, "trackedUser")
 		reportingURL := parsedURL.String()
 
-		a := aggregator.NewTrackedUsersInAppAggregator(db, stats, conf, module, log)
+		a := aggregator.NewTrackedUsersInAppAggregator(db, stats, conf, module)
 		f, err := NewFlusher(db, log, stats, conf, table, reportingURL, commonClient, a, module)
 		if err != nil {
 			return nil, fmt.Errorf("error creating flusher %w", err)

enterprise/trackedusers/users_reporter.go

@@ -38,8 +38,6 @@ const (
 	trackUsersTable = "tracked_users_reports"
 
 	eventTypeAlias = "alias"
-
-	problematicHLLValue = "5c78313139303766"
 )
 
 type UsersReport struct {
@@ -225,14 +223,6 @@ func (u *UniqueUsersReporter) ReportUsers(ctx context.Context, reports []*UsersR
 		if err != nil {
 			return fmt.Errorf("converting identified anon id hll to string: %w", err)
 		}
-
-		if userIDHllString == problematicHLLValue || anonIDHllString == problematicHLLValue || identifiedAnnIDHllString == problematicHLLValue {
-			u.log.Errorn("found problematic hll value before storing to database",
-				logger.NewStringField("workspace_id", report.WorkspaceID),
-				logger.NewStringField("source_id", report.SourceID),
-			)
-		}
-
 		_, err = stmt.Exec(report.WorkspaceID,
 			u.instanceID,
 			report.SourceID,