-
Notifications
You must be signed in to change notification settings - Fork 6
fix: missing keydb client stats #6360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktgowtham
approved these changes
Sep 17, 2025
mihir20
approved these changes
Sep 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/1.59.x #6360 +/- ##
==================================================
- Coverage 77.82% 77.65% -0.18%
==================================================
Files 523 523
Lines 70603 70231 -372
==================================================
- Hits 54945 54536 -409
- Misses 12807 12862 +55
+ Partials 2851 2833 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fracasula
pushed a commit
that referenced
this pull request
Sep 17, 2025
🤖 I have created a release *beep* *boop* --- ## [1.59.2](v1.59.1...v1.59.2) (2025-09-17) ### Bug Fixes * missing keydb client stats ([#6360](#6360)) ([5e395ad](5e395ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fracasula
added a commit
that referenced
this pull request
Sep 17, 2025
# Description Syncing patch release v1.59.2 to main branch **↓↓ Please review and edit commit overrides before merging ↓↓** BEGIN_COMMIT_OVERRIDE fix: add outgoing metrics to proxy flow (#6355) fix: aws session config region (#6354) fix: missing keydb client stats (#6360) END_COMMIT_OVERRIDE --------- Co-authored-by: Dilip Kola <[email protected]> Co-authored-by: Akash Chetty <[email protected]> Co-authored-by: Francesco Casula <[email protected]>
This was referenced Sep 19, 2025
This was referenced Sep 29, 2025
Merged
mihir20
pushed a commit
that referenced
this pull request
Sep 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.60.0-rc.1](v1.59.0...v1.60.0-rc.1) (2025-09-29) ### Features * **router:** jobsdb pickup query batch size adapting to throttling limit ([#6338](#6338)) ([c38b971](c38b971)) ### Bug Fixes * add outgoing metrics to proxy flow ([#6355](#6355)) ([23a5c81](23a5c81)) * aws session config region ([#6354](#6354)) ([23a5c81](23a5c81)) * dedup gauge ([#6359](#6359)) ([a562df4](a562df4)) * keydb grpc config ([#6370](#6370)) ([cf04743](cf04743)) * missing keydb client stats ([#6360](#6360)) ([c42e5c8](c42e5c8)) * naming collision in redis throttling configuration ([#6365](#6365)) ([4f87afb](4f87afb)) * set table type to external for glue ([#6386](#6386)) ([9017582](9017582)) * ut mirroring tests ([#6341](#6341)) ([51dd4f7](51dd4f7)) * **warehouse:** alter namespace col size ([#6379](#6379)) ([fbba498](fbba498)) * **warehouse:** skip extract async job failing test ([#6378](#6378)) ([89a4d1e](89a4d1e)) ### Miscellaneous * add authentication to reporting client ([#6384](#6384)) ([502d2b0](502d2b0)) * add explicit permissions for workflows ([#6381](#6381)) ([1d22623](1d22623)) * add readme for async destinaiton module ([#6356](#6356)) ([cc80333](cc80333)) * remove deprecated throttling configuration keys ([#6377](#6377)) ([8d667b7](8d667b7)) * upgrade build-scan-push-action to v1.8.0 ([#6350](#6350)) ([51dd4f7](51dd4f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mihir20
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [1.60.0-rc.2](v1.59.0...v1.60.0-rc.2) (2025-09-30) ### Features * **router:** jobsdb pickup query batch size adapting to throttling limit ([#6338](#6338)) ([c38b971](c38b971)) ### Bug Fixes * add outgoing metrics to proxy flow ([#6355](#6355)) ([23a5c81](23a5c81)) * aws session config region ([#6354](#6354)) ([23a5c81](23a5c81)) * dedup gauge ([#6359](#6359)) ([a562df4](a562df4)) * keydb grpc config ([#6370](#6370)) ([cf04743](cf04743)) * missing keydb client stats ([#6360](#6360)) ([c42e5c8](c42e5c8)) * naming collision in redis throttling configuration ([#6365](#6365)) ([4f87afb](4f87afb)) * set table type to external for glue ([#6386](#6386)) ([9017582](9017582)) * ut mirroring tests ([#6341](#6341)) ([51dd4f7](51dd4f7)) * **warehouse:** alter namespace col size ([#6379](#6379)) ([fbba498](fbba498)) * **warehouse:** skip extract async job failing test ([#6378](#6378)) ([89a4d1e](89a4d1e)) ### Miscellaneous * add authentication to reporting client ([#6384](#6384)) ([502d2b0](502d2b0)) * add explicit permissions for workflows ([#6381](#6381)) ([1d22623](1d22623)) * add readme for async destinaiton module ([#6356](#6356)) ([cc80333](cc80333)) * configurable event name trimming for reporting ([#6394](#6394)) ([7628efa](7628efa)) * remove deprecated throttling configuration keys ([#6377](#6377)) ([8d667b7](8d667b7)) * upgrade build-scan-push-action to v1.8.0 ([#6350](#6350)) ([51dd4f7](51dd4f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 30, 2025
mihir20
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [1.60.0-rc.3](v1.59.0...v1.60.0-rc.3) (2025-09-30) ### Features * **router:** jobsdb pickup query batch size adapting to throttling limit ([#6338](#6338)) ([c38b971](c38b971)) ### Bug Fixes * add outgoing metrics to proxy flow ([#6355](#6355)) ([23a5c81](23a5c81)) * aws session config region ([#6354](#6354)) ([23a5c81](23a5c81)) * dedup gauge ([#6359](#6359)) ([a562df4](a562df4)) * keydb consistent hashing ([#6403](#6403)) ([3ee79b2](3ee79b2)) * keydb grpc config ([#6370](#6370)) ([cf04743](cf04743)) * missing keydb client stats ([#6360](#6360)) ([c42e5c8](c42e5c8)) * naming collision in redis throttling configuration ([#6365](#6365)) ([4f87afb](4f87afb)) * set table type to external for glue ([#6386](#6386)) ([9017582](9017582)) * ut mirroring tests ([#6341](#6341)) ([51dd4f7](51dd4f7)) * **warehouse:** alter namespace col size ([#6379](#6379)) ([fbba498](fbba498)) * **warehouse:** skip extract async job failing test ([#6378](#6378)) ([89a4d1e](89a4d1e)) ### Miscellaneous * add authentication to reporting client ([#6384](#6384)) ([502d2b0](502d2b0)) * add explicit permissions for workflows ([#6381](#6381)) ([1d22623](1d22623)) * add readme for async destinaiton module ([#6356](#6356)) ([cc80333](cc80333)) * configurable event name trimming for reporting ([#6394](#6394)) ([7628efa](7628efa)) * remove deprecated throttling configuration keys ([#6377](#6377)) ([8d667b7](8d667b7)) * upgrade build-scan-push-action to v1.8.0 ([#6350](#6350)) ([51dd4f7](51dd4f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mihir20
pushed a commit
that referenced
this pull request
Oct 1, 2025
🤖 I have created a release *beep* *boop* --- ## [1.60.0](v1.59.0...v1.60.0) (2025-09-30) ### Features * **router:** jobsdb pickup query batch size adapting to throttling limit ([#6338](#6338)) ([c38b971](c38b971)) ### Bug Fixes * add outgoing metrics to proxy flow ([#6355](#6355)) ([23a5c81](23a5c81)) * aws session config region ([#6354](#6354)) ([23a5c81](23a5c81)) * dedup gauge ([#6359](#6359)) ([a562df4](a562df4)) * keydb consistent hashing ([#6403](#6403)) ([3ee79b2](3ee79b2)) * keydb grpc config ([#6370](#6370)) ([cf04743](cf04743)) * missing keydb client stats ([#6360](#6360)) ([c42e5c8](c42e5c8)) * naming collision in redis throttling configuration ([#6365](#6365)) ([4f87afb](4f87afb)) * set table type to external for glue ([#6386](#6386)) ([9017582](9017582)) * ut mirroring tests ([#6341](#6341)) ([51dd4f7](51dd4f7)) * **warehouse:** alter namespace col size ([#6379](#6379)) ([fbba498](fbba498)) * **warehouse:** skip extract async job failing test ([#6378](#6378)) ([89a4d1e](89a4d1e)) ### Miscellaneous * add authentication to reporting client ([#6384](#6384)) ([502d2b0](502d2b0)) * add explicit permissions for workflows ([#6381](#6381)) ([1d22623](1d22623)) * add readme for async destinaiton module ([#6356](#6356)) ([cc80333](cc80333)) * configurable event name trimming for reporting ([#6394](#6394)) ([7628efa](7628efa)) * remove deprecated throttling configuration keys ([#6377](#6377)) ([8d667b7](8d667b7)) * upgrade build-scan-push-action to v1.8.0 ([#6350](#6350)) ([51dd4f7](51dd4f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mihir20
pushed a commit
that referenced
this pull request
Oct 1, 2025
🤖 I have created a release *beep* *boop* --- ## [1.60.0](v1.59.0...v1.60.0) (2025-09-30) ### Features * **router:** jobsdb pickup query batch size adapting to throttling limit ([#6338](#6338)) ([c38b971](c38b971)) ### Bug Fixes * add outgoing metrics to proxy flow ([#6355](#6355)) ([23a5c81](23a5c81)) * aws session config region ([#6354](#6354)) ([23a5c81](23a5c81)) * dedup gauge ([#6359](#6359)) ([a562df4](a562df4)) * keydb consistent hashing ([#6403](#6403)) ([3ee79b2](3ee79b2)) * keydb grpc config ([#6370](#6370)) ([cf04743](cf04743)) * missing keydb client stats ([#6360](#6360)) ([c42e5c8](c42e5c8)) * naming collision in redis throttling configuration ([#6365](#6365)) ([4f87afb](4f87afb)) * set table type to external for glue ([#6386](#6386)) ([9017582](9017582)) * ut mirroring tests ([#6341](#6341)) ([51dd4f7](51dd4f7)) * **warehouse:** alter namespace col size ([#6379](#6379)) ([fbba498](fbba498)) * **warehouse:** skip extract async job failing test ([#6378](#6378)) ([89a4d1e](89a4d1e)) ### Miscellaneous * add authentication to reporting client ([#6384](#6384)) ([502d2b0](502d2b0)) * add explicit permissions for workflows ([#6381](#6381)) ([1d22623](1d22623)) * add readme for async destinaiton module ([#6356](#6356)) ([cc80333](cc80333)) * configurable event name trimming for reporting ([#6394](#6394)) ([7628efa](7628efa)) * remove deprecated throttling configuration keys ([#6377](#6377)) ([8d667b7](8d667b7)) * upgrade build-scan-push-action to v1.8.0 ([#6350](#6350)) ([51dd4f7](51dd4f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding keydb client stats.
Linear Ticket
Fixes PIPE-2404
Security