Skip to content

Ruffle logo on the front-page isn't displayed correctly on Safari #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Korne127 opened this issue Apr 12, 2023 · 5 comments · Fixed by #144
Closed

Ruffle logo on the front-page isn't displayed correctly on Safari #143

Korne127 opened this issue Apr 12, 2023 · 5 comments · Fixed by #144

Comments

@Korne127
Copy link

The Ruffle logo (SWF) that is embedded on the front-page (https://ruffle.rs) isn't displayed correctly on Safari on macOS.
On Firefox, the website looks like this (which is probably how it's intended):
Ruffle-Logo Firefox

However, on Safari, the website looks like this:
Ruffle-Logo Safari

The logo seems to be way too small, and as a result there is a huge amount of blank space. The animation itself works correctly though.

Additionally, when loading the website in Safari, it looks like this:

Ruffle-Logo.Safari.mov

As you see, there is a text (Backup all saves (download all sols)) with a horizontal line for a short amount of time before the logo is loaded and the animation is starting.

@danielhjacobs
Copy link
Collaborator

danielhjacobs commented Apr 12, 2023

What version of Safari are you using? The dialog element for the save manager not working properly points to a version before 15.4: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

@Korne127
Copy link
Author

That's probably the issue. I'm still on macOS 11 (Big Sur) and since the Safari versions are tied to the macOS versions, I'm using Safari 14.
However, if the front-page depends on an element that doesn't work in some rather new browser versions to be rendered correctly, I'd suggest to have a fallback to display it correctly for browsers that don't support it (if it couldn't work with the SWF file, maybe a static logo) or at least a note that the website isn't displayed correctly in the current browser.

@danielhjacobs
Copy link
Collaborator

The Ruffle logo being the wrong size is because the Ruffle home page uses aspect-ratio.

@Korne127
Copy link
Author

Ah, I understand. Well, I am not really an HTML/CSS expert, but could be padding-top: 56.25%; /* 16:9 aspect ratio */ used instead of (or additionally to??) the aspect-ratio tag to achieve a greater compatibility?

@danielhjacobs
Copy link
Collaborator

I tried that out a bit, but it doesn't seem to keep the size responsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants