Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: shepmaster/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rework
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 151 files changed
  • 1 contributor

Commits on Mar 28, 2025

  1. Move eager translation to a method on Diag 

    This will allow us to eagerly translate messages on a top-level
diagnostic, such as a `LintDiagnostic`. As a bonus, we can remove the
awkward closure passed into Subdiagnostic and make better use of
`Into`.
    @shepmaster
    shepmaster committed Mar 28, 2025
    Configuration menu
    Copy the full SHA
    2733a3b View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2025

  1. Extend HIR to track the source and syntax of a lifetime 

    An upcoming lint will want to be able to know if a lifetime is
hidden (e.g. `&u8`, `ContainsLifetime`) or anonymous: (e.g. `&'_ u8`,
`ContainsLifetime<'_>`). It will also want to know if the lifetime is
related to a reference (`&u8`) or a path (`ContainsLifetime`).
    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    9b312a2 View commit details
    Browse the repository at this point in the history

  2. Introduce the mismatched_lifetime_syntaxes lint

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    3704bd0 View commit details
    Browse the repository at this point in the history

  3. Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    162c588 View commit details
    Browse the repository at this point in the history

  4. Test elided-lifetimes-in-paths outside of function signatures

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    5b30a6f View commit details
    Browse the repository at this point in the history

  5. Support trailing comma in add_lint_group!

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    9662508 View commit details
    Browse the repository at this point in the history

  6. Add a helper to rename lint groups

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    bef669b View commit details
    Browse the repository at this point in the history

  7. Handle documenting a lint that was renamed to a group

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    27a5e71 View commit details
    Browse the repository at this point in the history

  8. Extend HIR to track the source of a type

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    d923925 View commit details
    Browse the repository at this point in the history

  9. Add new HIR implementations of hidden lifetimes in paths lints

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    db3f5a1 View commit details
    Browse the repository at this point in the history

  10. Replace elided_lifetime_in_paths with multiple renamed lints 

    Removing the `issue-91763` test as the implementation is completely
different now.

Bootstrap forces `rust_2018_idioms` to the warning level in the
rustc_lint doctests using `-Zcrate-attr`. This overrides the doctest's
crate-level `deny` attributes, so I've changed those to be
statement-level attributes.
    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    718d201 View commit details
    Browse the repository at this point in the history

  11. Warn about hidden_lifetimes_in_output_paths by default

    @shepmaster
    shepmaster committed Mar 29, 2025
    Configuration menu
    Copy the full SHA
    5c08642 View commit details
    Browse the repository at this point in the history
Loading