Skip to content

Add support to release aarch64 wheels #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odidev opened this issue Jun 1, 2021 · 3 comments
Closed

Add support to release aarch64 wheels #347

odidev opened this issue Jun 1, 2021 · 3 comments

Comments

@odidev
Copy link

odidev commented Jun 1, 2021

Problem

On aarch64, pip install libsass builds the wheels from source code and then install it. It requires user to have development environment installed on his system. also, it take some time to build the wheels than downloading and extracting the wheels from pypi.

Resolution

On aarch64, pip install libsass should be able to download the wheels from pypi

@asottile, Please let me know your interest on releasing aarch64 wheels. I can help in this.

@asottile
Copy link
Member

asottile commented Jun 1, 2021

dupe #341

@asottile asottile closed this as completed Jun 1, 2021
@asottile
Copy link
Member

asottile commented Jun 1, 2021

also I think you'll recall our discussion here: hynek/argon2-cffi#74

@aaugustin
Copy link

aaugustin commented Aug 27, 2022

Hello, I just wasted a stupid amount of time figuring out why pip wouldn't install libsass from wheels in a container and chose to install from source instead:

$ docker run -it --rm python:3.10-slim /bin/bash
root@187d1396c785:/# pip install libsass
Collecting libsass
  Downloading libsass-0.21.0.tar.gz (317 kB)
...
      error: command 'gcc' failed: No such file or directory
...
...

Eventually I tracked it down to this issue.

Of course, the workaround is "just" apt-get install build-essentials in my Dockerfile. Is it really a good trade-off to have a fraction of your users to jump through this hoop, though?

I can understand your argument about publishing potentially non-compliant wheels. The counter-argument would be:

  • Until there's a standard, there's no risk of being non-compliant.
  • When there's a standard, at worst, you can bump the version number and publish compliant wheels. I wouldn't expect the previous, potentially non-compliant, to cause significant harm. At least, not enough to outweigh the convenience of being able to install libsass without jumping through hoops.

That's why I estimate that the pros of publishing aarch64 wheels outweigh the cons at this point in time.

In case it helps, cibuildwheel + GitHub actions makes it easy to create aarch64 wheels (among many others). I understand that you aren't currently using that toolchain, perhaps for good reasons. I'm not an expert here, just a maintainer of a few Python packages and user of libsass :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants