Skip to content

Commit ed69be7

Browse files
authored
Merge pull request #429 from japgolly/bug/idbNewVer
IDBVersionChangeEvent.newVersion can be null
2 parents 968af4a + 3182de1 commit ed69be7

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

api-reports/2_12.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -15219,7 +15219,7 @@ raw/IDBVersionChangeEvent[JC] def currentTarget: EventTarget
1521915219
raw/IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
1522015220
raw/IDBVersionChangeEvent[JC] def eventPhase: Int
1522115221
raw/IDBVersionChangeEvent[JC] def isTrusted: Boolean
15222-
raw/IDBVersionChangeEvent[JC] def newVersion: Int
15222+
raw/IDBVersionChangeEvent[JC] def newVersion: Integer
1522315223
raw/IDBVersionChangeEvent[JC] def oldVersion: Int
1522415224
raw/IDBVersionChangeEvent[JC] def preventDefault(): Unit
1522515225
raw/IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
@@ -15230,7 +15230,7 @@ raw/IDBVersionChangeEvent[JC] def `type`: String
1523015230
raw/IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
1523115231
raw/IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
1523215232
raw/IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
15233-
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Int]
15233+
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
1523415234
raw/IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
1523515235
raw/IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
1523615236
raw/ImageData[JC] def data: js.Array[Int]

api-reports/2_13.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -15219,7 +15219,7 @@ raw/IDBVersionChangeEvent[JC] def currentTarget: EventTarget
1521915219
raw/IDBVersionChangeEvent[JC] def defaultPrevented: Boolean
1522015220
raw/IDBVersionChangeEvent[JC] def eventPhase: Int
1522115221
raw/IDBVersionChangeEvent[JC] def isTrusted: Boolean
15222-
raw/IDBVersionChangeEvent[JC] def newVersion: Int
15222+
raw/IDBVersionChangeEvent[JC] def newVersion: Integer
1522315223
raw/IDBVersionChangeEvent[JC] def oldVersion: Int
1522415224
raw/IDBVersionChangeEvent[JC] def preventDefault(): Unit
1522515225
raw/IDBVersionChangeEvent[JC] def stopImmediatePropagation(): Unit
@@ -15230,7 +15230,7 @@ raw/IDBVersionChangeEvent[JC] def `type`: String
1523015230
raw/IDBVersionChangeEventInit[JT] var bubbles: js.UndefOr[Boolean]
1523115231
raw/IDBVersionChangeEventInit[JT] var cancelable: js.UndefOr[Boolean]
1523215232
raw/IDBVersionChangeEventInit[JT] var composed: js.UndefOr[Boolean]
15233-
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Int]
15233+
raw/IDBVersionChangeEventInit[JT] var newVersion: js.UndefOr[Integer]
1523415234
raw/IDBVersionChangeEventInit[JT] var oldVersion: js.UndefOr[Int]
1523515235
raw/IDBVersionChangeEventInit[JT] var scoped: js.UndefOr[Boolean]
1523615236
raw/ImageData[JC] def data: js.Array[Int]

src/main/scala/org/scalajs/dom/raw/Idb.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class IDBObjectStore extends js.Object {
123123
}
124124

125125
trait IDBVersionChangeEventInit extends EventInit {
126-
var newVersion: js.UndefOr[Int] = js.undefined
126+
var newVersion: js.UndefOr[Integer] = js.undefined
127127
var oldVersion: js.UndefOr[Int] = js.undefined
128128
}
129129

@@ -142,9 +142,11 @@ class IDBVersionChangeEvent(typeArg: String,
142142
/**
143143
* Returns the new version of the database.
144144
*
145+
* This is null when the database is being deleted.
146+
*
145147
* MDN
146148
*/
147-
def newVersion: Int = js.native
149+
def newVersion: Integer = js.native
148150

149151
/**
150152
* Returns the old version of the database.

0 commit comments

Comments
 (0)