test(rsync,ssh): test remote filenames with spaces using mock commands

Author: Rogach

completions/rsync

@@ -5,8 +5,9 @@ _comp_cmd_rsync__vercomp()
     if [[ $1 == "$2" ]]; then
         return 0
     fi
-    local IFS=.
-    local i ver1=($1) ver2=($2)
+    local i ver1 ver2
+    _comp_split -F . ver1 "$1"
+    _comp_split -F . ver2 "$2"
     local n=$((${#ver1[@]} >= ${#ver2[@]} ? ${#ver1[@]} : ${#ver2[@]}))
     for ((i = 0; i < n; i++)); do
         if ((10#${ver1[i]:-0} > 10#${ver2[i]:-0})); then

test/t/test_rsync.py

@@ -1,8 +1,6 @@
 import pytest
 
-from conftest import assert_bash_exec
-
-LIVE_HOST = "bash_completion"
+from conftest import assert_bash_exec, assert_complete
 
 
 @pytest.mark.bashcomp(ignore_env=r"^[+-]_comp_cmd_scp__path_esc=")
@@ -67,8 +65,10 @@ def test_vercomp(self, bash, ver1, ver2, result):
         else:
             raise Exception(f"Unsupported comparison result: {result}")
 
-    @pytest.mark.complete(f"rsync {LIVE_HOST}:spaces", sleep_after_tab=2)
-    def test_remote_path_with_spaces(self, completion):
+    def test_remote_path_with_spaces(self, bash):
+        assert_bash_exec(bash, "ssh() { echo 'spaces in filename.txt'; }")
+        completion = assert_complete(bash, "rsync remote_host:spaces")
+        assert_bash_exec(bash, "unset -f ssh")
         assert (
             completion == r"\ in\ filename.txt"
             or completion == r"\\\ in\\\ filename.txt"

test/t/test_scp.py

@@ -2,7 +2,7 @@
 
 import pytest
 
-from conftest import assert_bash_exec
+from conftest import assert_bash_exec, assert_complete
 
 LIVE_HOST = "bash_completion"
 
@@ -96,6 +96,8 @@ def test_remote_path_with_nullglob(self, completion):
     def test_remote_path_with_failglob(self, completion):
         assert not completion
 
-    @pytest.mark.complete(f"scp {LIVE_HOST}:spaces", sleep_after_tab=2)
-    def test_remote_path_with_spaces(self, live_pwd, completion):
+    def test_remote_path_with_spaces(self, bash):
+        assert_bash_exec(bash, "ssh() { echo 'spaces in filename.txt'; }")
+        completion = assert_complete(bash, "scp remote_host:spaces")
+        assert_bash_exec(bash, "unset -f ssh")
         assert completion == r"\\\ in\\\ filename.txt"