Skip to content

Commit 02a056a

Browse files
committed
style: update JACK example comments to match ALSA format
1 parent 6bf077f commit 02a056a

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

patchrrr.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,14 @@
2323
]
2424

2525
JACK_DESIRED_CONNECTIONS = [
26-
("pure_data:output_1", "system:playback_9"),
27-
("pure_data:output_2", "system:playback_10"),
26+
# Add your JACK audio connections here.
27+
# Examples:
28+
# ("pure_data:output_1", "system:playback_1"),
29+
# ("pure_data:output_2", "Built-in Audio Analog Stereo:playback_FR"),
2830
]
2931

32+
# Patchrrr creates Jack and ALSA clients because these are required to implement
33+
# our functionality
3034
CLIENT_NAME = "patchrrr"
3135

3236
# ---------------------------------------------------------------------------
@@ -741,11 +745,11 @@ def reconcile_connections(self):
741745
# Unified Manager
742746
class PatchrrrManager:
743747
"""Unified ALSA MIDI + JACK audio connection manager."""
744-
748+
745749
def __init__(self, alsa_connections=None, jack_connections=None):
746750
"""
747751
Initialize the manager with desired connections.
748-
752+
749753
Args:
750754
alsa_connections: List of (source, dest) tuples for ALSA MIDI
751755
jack_connections: List of (source, dest) tuples for JACK audio
@@ -755,28 +759,28 @@ def __init__(self, alsa_connections=None, jack_connections=None):
755759
self.running = True
756760
self.alsa_mgr = None
757761
self.jack_mgr = None
758-
762+
759763
def signal_handler(self, sig, frame):
760764
"""Handle shutdown signals."""
761765
print("\nSignal received, shutting down...")
762766
self.running = False
763-
767+
764768
def start(self):
765769
"""Start all managers and begin monitoring."""
766770
signal.signal(signal.SIGINT, self.signal_handler)
767771
signal.signal(signal.SIGTERM, self.signal_handler)
768-
772+
769773
self.alsa_mgr = AlsaManager(self.alsa_connections)
770774
self.jack_mgr = JackManager(self.jack_connections)
771-
775+
772776
# Start ALSA in its own thread because it uses blocking reads
773777
alsa_thread = threading.Thread(target=self.alsa_mgr.run, daemon=True)
774778
alsa_thread.start()
775-
779+
776780
# Start JACK in its own thread for symmetry
777781
jack_thread = threading.Thread(target=self.jack_mgr.run, daemon=True)
778782
jack_thread.start()
779-
783+
780784
# Central dispatcher loop
781785
try:
782786
while self.running:
@@ -791,7 +795,7 @@ def start(self):
791795
finally:
792796
self.stop()
793797
print("\nAll managers shut down. Goodbye!")
794-
798+
795799
def stop(self):
796800
"""Stop all managers."""
797801
if self.alsa_mgr:

0 commit comments

Comments
 (0)