From af170249de6fbea4ee22e04408a49b2704f8f7e8 Mon Sep 17 00:00:00 2001 From: Laurens Lavaert Date: Sat, 15 Jul 2023 08:37:37 +0200 Subject: [PATCH 1/2] Do not throw error when analytics are disabled. Imagine the following case where you disable segment in your code. const { Analytics } = require('@segment/analytics-node'); new Analytics({ writeKey: processe.env.WRITE_KEY || '', disable: true }); If WRITE_KEY is not present, but your analytics are disabled this still throws an error. This would simplify local setups and do not force them to have a truthy string as write key --- packages/node/src/app/settings.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node/src/app/settings.ts b/packages/node/src/app/settings.ts index 0f2ee02f6..5b01e4bf3 100644 --- a/packages/node/src/app/settings.ts +++ b/packages/node/src/app/settings.ts @@ -43,7 +43,7 @@ export interface AnalyticsSettings { } export const validateSettings = (settings: AnalyticsSettings) => { - if (!settings.writeKey) { + if (!settings.writeKey && !settings.disable) { throw new ValidationError('writeKey', 'writeKey is missing.') } } From d25217d4eda3e06dcd06e665afcd939a71ae20ac Mon Sep 17 00:00:00 2001 From: Christopher Radek <14189820+chrisradek@users.noreply.github.com> Date: Tue, 18 Jul 2023 10:28:44 -0700 Subject: [PATCH 2/2] Add changeset --- .changeset/breezy-buttons-hope.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/breezy-buttons-hope.md diff --git a/.changeset/breezy-buttons-hope.md b/.changeset/breezy-buttons-hope.md new file mode 100644 index 000000000..7e3a39b74 --- /dev/null +++ b/.changeset/breezy-buttons-hope.md @@ -0,0 +1,5 @@ +--- +"@segment/analytics-node": patch +--- + +The writeKey no longer needs to be defined when setting `disabled` is `true`.