Skip to content

Commit 2dcfb78

Browse files
committed
fixed handle close page connections
1 parent aa7b2fe commit 2dcfb78

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

seleniumbase/plugins/sb_manager.py

+5-7
Original file line numberDiff line numberDiff line change
@@ -1367,13 +1367,11 @@ def SB(
13671367
"%s%s%s%s%s"
13681368
% (c1, left_space, end_text, right_space, cr)
13691369
)
1370-
if hasattr(sb_config, "_cdp_aclose"):
1371-
import asyncio
1372-
with suppress(Exception):
1373-
loop = asyncio.get_event_loop()
1374-
asyncio.set_event_loop(loop)
1375-
loop.run_until_complete(sb_config._cdp_aclose())
1376-
loop.close()
1370+
for driver_browser in sb._drivers_browser_map.keys():
1371+
if driver_browser.cdp is not None:
1372+
driver_browser.cdp.loop.run_until_complete(driver_browser.cdp.page.aclose())
1373+
driver_browser.cdp.loop.close()
1374+
13771375
gc.collect()
13781376
if test and test_name and not test_passed and raise_test_failure:
13791377
raise exception

seleniumbase/undetected/cdp_driver/connection.py

-2
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,6 @@ async def aopen(self, **kw):
271271
max_size=MAX_SIZE,
272272
)
273273
self.listener = Listener(self)
274-
sb_config._cdp_aclose = self.aclose
275274
except (Exception,) as e:
276275
logger.debug("Exception during opening of websocket: %s", e)
277276
if self.listener:
@@ -446,7 +445,6 @@ async def send(
446445
if not _is_update:
447446
await self._register_handlers()
448447
await self.websocket.send(tx.message)
449-
sb_config._cdp_aclose = self.aclose
450448
try:
451449
return await tx
452450
except ProtocolException as e:

0 commit comments

Comments
 (0)