Skip to content

Commit 155812f

Browse files
committed
Flag tests that are failing for Chrome on my OS X machine
With chromedriver 2.28 and chrome 57.
1 parent a23a067 commit 155812f

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

java/client/test/org/openqa/selenium/AlertsTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050

5151
import java.util.Set;
5252

53-
@Ignore({PHANTOMJS, SAFARI})
53+
@Ignore(value = {CHROME, PHANTOMJS, SAFARI},
54+
reason = "chrome: https://bugs.chromium.org/p/chromedriver/issues/detail?id=1500")
5455
public class AlertsTest extends JUnit4TestBase {
5556

5657
@Before

java/client/test/org/openqa/selenium/ClickScrollingTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.openqa.selenium.testing.Ignore;
3737
import org.openqa.selenium.testing.JUnit4TestBase;
3838
import org.openqa.selenium.testing.JavascriptEnabled;
39+
import org.openqa.selenium.testing.NotYetImplemented;
3940
import org.openqa.selenium.testing.SwitchToTopAfterTest;
4041

4142
@Ignore(value = {HTMLUNIT}, reason = "HtmlUnit: Scrolling requires rendering")
@@ -194,6 +195,7 @@ public void testShouldBeAbleToClickElementThatIsOutOfViewInAFrameThatIsOutOfView
194195
@SwitchToTopAfterTest
195196
@Test
196197
@Ignore(value = {SAFARI}, reason = "not tested")
198+
@NotYetImplemented(value = CHROME, reason = "Apparently doesn't click properly")
197199
public void testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrame() {
198200
driver.get(appServer.whereIs("scrolling_tests/page_with_nested_scrolling_frames.html"));
199201
driver.switchTo().frame("scrolling_frame");
@@ -206,6 +208,7 @@ public void testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrame() {
206208
@SwitchToTopAfterTest
207209
@Test
208210
@Ignore(value = {SAFARI}, reason = "not tested")
211+
@NotYetImplemented(value = CHROME, reason = "Apparently doesn't click properly")
209212
public void testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrameThatIsOutOfView() {
210213
driver.get(appServer.whereIs("scrolling_tests/page_with_nested_scrolling_frames_out_of_view.html"));
211214
driver.switchTo().frame("scrolling_frame");

java/client/test/org/openqa/selenium/TakesScreenshotTest.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import org.junit.Test;
4343
import org.openqa.selenium.testing.Ignore;
4444
import org.openqa.selenium.testing.JUnit4TestBase;
45+
import org.openqa.selenium.testing.NotYetImplemented;
4546
import org.openqa.selenium.testing.SwitchToTopAfterTest;
4647
import org.openqa.selenium.testing.drivers.SauceDriver;
4748

@@ -81,13 +82,13 @@
8182
@Ignore(value = {IE}, reason = "IE: strange colors appeared")
8283
public class TakesScreenshotTest extends JUnit4TestBase {
8384

84-
private TakesScreenshot screenshoter;
85+
private TakesScreenshot screenshooter;
8586
private File tempFile = null;
8687

8788
@Before
8889
public void setUp() throws Exception {
8990
assumeTrue(driver instanceof TakesScreenshot);
90-
screenshoter = (TakesScreenshot) driver;
91+
screenshooter = (TakesScreenshot) driver;
9192
}
9293

9394
@After
@@ -101,26 +102,27 @@ public void tearDown() {
101102
@Test
102103
public void testGetScreenshotAsFile() throws Exception {
103104
driver.get(pages.simpleTestPage);
104-
tempFile = screenshoter.getScreenshotAs(OutputType.FILE);
105+
tempFile = screenshooter.getScreenshotAs(OutputType.FILE);
105106
assertTrue(tempFile.exists());
106107
assertTrue(tempFile.length() > 0);
107108
}
108109

109110
@Test
110111
public void testGetScreenshotAsBase64() throws Exception {
111112
driver.get(pages.simpleTestPage);
112-
String screenshot = screenshoter.getScreenshotAs(OutputType.BASE64);
113+
String screenshot = screenshooter.getScreenshotAs(OutputType.BASE64);
113114
assertTrue(screenshot.length() > 0);
114115
}
115116

116117
@Test
117118
public void testGetScreenshotAsBinary() throws Exception {
118119
driver.get(pages.simpleTestPage);
119-
byte[] screenshot = screenshoter.getScreenshotAs(OutputType.BYTES);
120+
byte[] screenshot = screenshooter.getScreenshotAs(OutputType.BYTES);
120121
assertTrue(screenshot.length > 0);
121122
}
122123

123124
@Test
125+
@NotYetImplemented(value = CHROME, reason = "Fails unexpectedly")
124126
public void testShouldCaptureScreenshotOfCurrentViewport() throws Exception {
125127
// Fails on Sauce for whatever reason; probably display or window manager.
126128
assumeFalse(SauceDriver.shouldUseSauce()
@@ -261,6 +263,7 @@ public void testShouldCaptureScreenshotOfPageWithTooLongXandY() throws Exception
261263
value = {IE},
262264
reason = " IE: v9 shows strange border which broke color comparison"
263265
)
266+
@NotYetImplemented(value = CHROME, reason = "Fails unexpectedly")
264267
public void testShouldCaptureScreenshotAtFramePage() throws Exception {
265268
// Fails on Sauce for whatever reason; probably display or window manager.
266269
assumeFalse(SauceDriver.shouldUseSauce()
@@ -327,6 +330,7 @@ public void testShouldCaptureScreenshotAtIFramePage() throws Exception {
327330
value = {IE, MARIONETTE},
328331
reason = "IE: v9 shows strange border which broke color comparison"
329332
)
333+
@NotYetImplemented(value = CHROME, reason = "Fails unexpectedly")
330334
public void testShouldCaptureScreenshotAtFramePageAfterSwitching() throws Exception {
331335
// Fails on Sauce for whatever reason; probably display or window manager.
332336
assumeFalse(SauceDriver.shouldUseSauce()
@@ -397,7 +401,7 @@ public void testShouldCaptureScreenshotAtIFramePageAfterSwitching() throws Excep
397401
private BufferedImage getImage() {
398402
BufferedImage image = null;
399403
try {
400-
byte[] imageData = screenshoter.getScreenshotAs(OutputType.BYTES);
404+
byte[] imageData = screenshooter.getScreenshotAs(OutputType.BYTES);
401405
assertTrue(imageData != null);
402406
assertTrue(imageData.length > 0);
403407
image = ImageIO.read(new ByteArrayInputStream(imageData));

0 commit comments

Comments
 (0)