Skip to content

Commit 1e28b3b

Browse files
committed
Ignoring tests that don't pass in htmlunit with JS off
1 parent d360ccf commit 1e28b3b

File tree

6 files changed

+17
-0
lines changed

6 files changed

+17
-0
lines changed

java/client/test/org/openqa/selenium/AlertsTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -474,6 +474,7 @@ public void testIncludesAlertTextInUnhandledAlertException() {
474474
assertThat(t.getMessage(), containsString("cheese"));
475475
}
476476

477+
@JavascriptEnabled
477478
@NoDriverAfterTest
478479
@Test
479480
public void testCanQuitWhenAnAlertIsPresent() {

java/client/test/org/openqa/selenium/ContentEditableTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ public void testShouldBeAbleToTypeIntoContentEditableElementWithExistingValue()
110110
assertThat(editable.getText(), equalTo(initialText + ", edited"));
111111
}
112112

113+
@JavascriptEnabled
113114
@Test
114115
@Ignore(IE)
115116
@Ignore(value = SAFARI, reason = "cannot type on contentEditable with synthetic events, issue 3127")
@@ -126,6 +127,7 @@ public void testShouldBeAbleToTypeIntoTinyMCE() {
126127
assertThat(editable.getText(), equalTo("cheese"));
127128
}
128129

130+
@JavascriptEnabled
129131
@Test
130132
@Ignore(CHROME)
131133
@Ignore(IE)

java/client/test/org/openqa/selenium/FormHandlingTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.junit.Test;
3838
import org.openqa.selenium.testing.Ignore;
3939
import org.openqa.selenium.testing.JUnit4TestBase;
40+
import org.openqa.selenium.testing.JavascriptEnabled;
4041
import org.openqa.selenium.testing.NotYetImplemented;
4142
import org.openqa.selenium.testing.TestUtilities;
4243

@@ -266,6 +267,7 @@ public void testEmptyTextBoxesShouldReturnAnEmptyStringNotNull() {
266267
assertEquals(emptyTextBox.getAttribute("value"), "");
267268
}
268269

270+
@JavascriptEnabled
269271
@Test
270272
@Ignore(PHANTOMJS)
271273
@Ignore(SAFARI)

java/client/test/org/openqa/selenium/ReferrerTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.openqa.selenium.support.ui.WebDriverWait;
5151
import org.openqa.selenium.testing.Ignore;
5252
import org.openqa.selenium.testing.JUnit4TestBase;
53+
import org.openqa.selenium.testing.JavascriptEnabled;
5354
import org.openqa.selenium.testing.NeedsLocalEnvironment;
5455
import org.openqa.selenium.testing.drivers.WebDriverBuilder;
5556
import org.seleniumhq.jetty9.server.Handler;
@@ -119,6 +120,7 @@ public static void readPages() throws IOException {
119120
* Tests navigation when all of the files are hosted on the same domain and the browser
120121
* does not have a proxy configured.
121122
*/
123+
@JavascriptEnabled
122124
@Test
123125
@NeedsLocalEnvironment
124126
public void basicHistoryNavigationWithoutAProxy() {
@@ -141,6 +143,7 @@ public void basicHistoryNavigationWithoutAProxy() {
141143
/**
142144
* Tests navigation across multiple domains when the browser does not have a proxy configured.
143145
*/
146+
@JavascriptEnabled
144147
@Test
145148
@NeedsLocalEnvironment
146149
public void crossDomainHistoryNavigationWithoutAProxy() {
@@ -171,6 +174,7 @@ public void crossDomainHistoryNavigationWithoutAProxy() {
171174
* Tests navigation when all of the files are hosted on the same domain and the browser is
172175
* configured to use a proxy that permits direct access to that domain.
173176
*/
177+
@JavascriptEnabled
174178
@Test
175179
@NeedsLocalEnvironment
176180
public void basicHistoryNavigationWithADirectProxy() {
@@ -199,6 +203,7 @@ public void basicHistoryNavigationWithADirectProxy() {
199203
* Tests navigation across multiple domains when the browser is configured to use a proxy that
200204
* permits direct access to those domains.
201205
*/
206+
@JavascriptEnabled
202207
@Test
203208
@NeedsLocalEnvironment
204209
public void crossDomainHistoryNavigationWithADirectProxy() {
@@ -233,6 +238,7 @@ public void crossDomainHistoryNavigationWithADirectProxy() {
233238
* Tests navigation across multiple domains when the browser is configured to use a proxy that
234239
* redirects the second domain to another host.
235240
*/
241+
@JavascriptEnabled
236242
@Test
237243
@Ignore(MARIONETTE)
238244
@NeedsLocalEnvironment
@@ -273,6 +279,7 @@ public void crossDomainHistoryNavigationWithAProxiedHost() {
273279
* intercepts requests to a specific host (www.example.com) - all other requests are permitted
274280
* to connect directly to the target server.
275281
*/
282+
@JavascriptEnabled
276283
@Test
277284
@Ignore(MARIONETTE)
278285
@NeedsLocalEnvironment
@@ -310,6 +317,7 @@ public void crossDomainHistoryNavigationWhenProxyInterceptsHostRequests() {
310317
* Tests navigation on a single domain where the browser is configured to use a proxy that
311318
* intercepts requests for page 2.
312319
*/
320+
@JavascriptEnabled
313321
@Test
314322
@Ignore(value = IE,
315323
reason = "IEDriver does not disable automatic proxy caching, causing this test to fail, issue 6629")

java/client/test/org/openqa/selenium/UnexpectedAlertBehaviorTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.openqa.selenium.support.ui.WebDriverWait;
3737
import org.openqa.selenium.testing.Ignore;
3838
import org.openqa.selenium.testing.JUnit4TestBase;
39+
import org.openqa.selenium.testing.JavascriptEnabled;
3940
import org.openqa.selenium.testing.NeedsLocalEnvironment;
4041
import org.openqa.selenium.testing.NotYetImplemented;
4142
import org.openqa.selenium.testing.TestUtilities;
@@ -63,12 +64,14 @@ public void canAcceptUnhandledAlert() {
6364
runScenarioWithUnhandledAlert(UnexpectedAlertBehaviour.ACCEPT, "This is a default value");
6465
}
6566

67+
@JavascriptEnabled
6668
@Test
6769
@Ignore(value = CHROME, reason = "Unstable Chrome behavior")
6870
public void canDismissUnhandledAlert() {
6971
runScenarioWithUnhandledAlert(UnexpectedAlertBehaviour.DISMISS, "null");
7072
}
7173

74+
@JavascriptEnabled
7275
@Test
7376
@Ignore(value = CHROME, reason = "Chrome uses IGNORE mode by default")
7477
public void dismissUnhandledAlertsByDefault() {

java/client/test/org/openqa/selenium/interactions/CombinedInputActionsTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ public void testCombiningShiftAndClickResultsInANewWindow() {
354354
assertEquals("Should not have navigated away.", originalTitle, driver.getTitle());
355355
}
356356

357+
@JavascriptEnabled
357358
@Test
358359
@Ignore(MARIONETTE)
359360
@Ignore(IE)

0 commit comments

Comments
 (0)