Add setting/getting proxy details to Firefox Options

This deprecates proxy and browser profile from instantiating
a new webdriver object and moves proxy to options so we only set it
in one place now.

Author: AutomatedTester

py/selenium/webdriver/firefox/options.py

@@ -14,7 +14,8 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
+from selenium.common.exceptions import InvalidArgumentException
+from selenium.webdriver.common.proxy import Proxy
 from selenium.webdriver.firefox.firefox_binary import FirefoxBinary
 from selenium.webdriver.firefox.firefox_profile import FirefoxProfile
 
@@ -36,6 +37,7 @@ def __init__(self):
         self._binary = None
         self._preferences = {}
         self._profile = None
+        self._proxy = None
         self._arguments = []
         self.log = Log()
 
@@ -71,6 +73,17 @@ def set_preference(self, name, value):
         """Sets a preference."""
         self._preferences[name] = value
 
+    @property
+    def proxy(self):
+        """ returns Proxy if set otherwise None."""
+        return self._proxy
+
+    @proxy.setter
+    def proxy(self, value):
+        if not isinstance(value, Proxy):
+            raise InvalidArgumentException("Only Proxy objects can be passed in.")
+        self._proxy = value
+
     @property
     def profile(self):
         """Returns the Firefox profile to use."""
@@ -112,6 +125,8 @@ def to_capabilities(self):
             opts["binary"] = self._binary._start_cmd
         if len(self._preferences) > 0:
             opts["prefs"] = self._preferences
+        if self._proxy is not None:
+            self._proxy.add_to_capabilities(opts)
         if self._profile is not None:
             opts["profile"] = self._profile.encoded
         if len(self._arguments) > 0:

py/selenium/webdriver/remote/webdriver.py

@@ -81,6 +81,8 @@ def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
         if not isinstance(desired_capabilities, dict):
             raise WebDriverException("Desired Capabilities must be a dictionary")
         if proxy is not None:
+            warnings.warn("Please use FirefoxOptions to set proxy",
+                          DeprecationWarning)
             proxy.add_to_capabilities(desired_capabilities)
         self.command_executor = command_executor
         if type(self.command_executor) is bytes or isinstance(self.command_executor, str):