Skip to content

Commit ca5f0b9

Browse files
committed
Clean up InternetExplorerDriver constructors to match ChromeDriver's
If someone wants to create a DriverService, they should do that and we don't need a wealth of constructors attempting to hide that fact from them.
1 parent 7414a5c commit ca5f0b9

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

java/client/src/org/openqa/selenium/ie/InternetExplorerDriver.java

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,19 +148,45 @@ public InternetExplorerDriver(Capabilities capabilities) {
148148
this(null, capabilities, DEFAULT_PORT);
149149
}
150150

151+
/**
152+
* @deprecated Create an {@link InternetExplorerDriverService} and then use that to create a
153+
* {@link RemoteWebDriver(org.openqa.selenium.remote.CommandExecutor, Capabilities)} with a
154+
* {@link DriverCommandExecutor}.
155+
*/
156+
@Deprecated
151157
public InternetExplorerDriver(int port) {
152158
this(null, null, port);
153159
}
154160

161+
/**
162+
* @deprecated Create an {@link InternetExplorerDriverService} and then use that to create a
163+
* {@link RemoteWebDriver(org.openqa.selenium.remote.CommandExecutor, Capabilities)} with a
164+
* {@link DriverCommandExecutor}.
165+
*/
166+
@Deprecated
155167
public InternetExplorerDriver(InternetExplorerDriverService service) {
156168
this(service, null, DEFAULT_PORT);
157169
}
158170

171+
/**
172+
* @deprecated Create an {@link InternetExplorerDriverService} and then use that to create a
173+
* {@link RemoteWebDriver(org.openqa.selenium.remote.CommandExecutor, Capabilities)} with a
174+
* {@link DriverCommandExecutor}.
175+
*/
176+
@Deprecated
159177
public InternetExplorerDriver(InternetExplorerDriverService service, Capabilities capabilities) {
160178
this(service, capabilities, DEFAULT_PORT);
161179
}
162180

163-
public InternetExplorerDriver(InternetExplorerDriverService service, Capabilities capabilities,
181+
/**
182+
* @deprecated Create an {@link InternetExplorerDriverService} and then use that to create a
183+
* {@link RemoteWebDriver(org.openqa.selenium.remote.CommandExecutor, Capabilities)} with a
184+
* {@link DriverCommandExecutor}.
185+
*/
186+
@Deprecated
187+
public InternetExplorerDriver(
188+
InternetExplorerDriverService service,
189+
Capabilities capabilities,
164190
int port) {
165191
if (capabilities == null) {
166192
capabilities = DesiredCapabilities.internetExplorer();

0 commit comments

Comments
 (0)