Skip to content

Consider setting up cargo fmt check on CI #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zrhoffman opened this issue Mar 26, 2024 · 3 comments
Closed

Consider setting up cargo fmt check on CI #375

zrhoffman opened this issue Mar 26, 2024 · 3 comments
Labels
enhancement help wanted

Comments

@zrhoffman
Copy link
Contributor

Once #373 is merged and cargo fmt produces no diff, cargo fmt --check should be added to the CI.
@zrhoffman zrhoffman changed the title Consider setting up cargo fmt check up on CI Consider setting up cargo fmt check on CI Mar 26, 2024
@emilio
Copy link
Member

emilio commented Apr 6, 2024

Yeah, we should do this. Also cargo clippy perhaps (with relevant ignores if needed), if it doesn't get too annoying.

@l4l
Copy link

l4l commented Apr 22, 2024

Resolved by #384?

@emilio
Copy link
Member

emilio commented Apr 22, 2024

Yes, indeed. Thanks!

@emilio emilio closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emilio @l4l @zrhoffman