Skip to content

Successful output in case of errors in the applying process #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinseii opened this issue Aug 2, 2024 · 5 comments
Closed

Successful output in case of errors in the applying process #278

kinseii opened this issue Aug 2, 2024 · 5 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@kinseii
Copy link

kinseii commented Aug 2, 2024

Problem:
In the applying process, if there was an error, the final output doesn't let you know about it:

19:53:07 [INFO] Applying unit 'qwerty-aks-us-1.test-configmap':
19:53:07 [INFO] [qwerty-aks-us-1][test-configmap][init] In progress...
19:53:07 [INFO] [qwerty-aks-us-1][test-configmap][init] executing in progress... 0s
19:53:08 [INFO] [qwerty-aks-us-1][test-configmap][init] Error
19:53:08 [INFO] The project was successfully applied

Cluster.dev Version:
cdev version v0.9.5

P.S.
To clarify, there was an error in the backend container name

@kinseii kinseii added the kind/bug Something isn't working label Aug 2, 2024
@kinseii
Copy link
Author

kinseii commented Aug 9, 2024

I did more research and came to the conclusion that it's a problem between backends in different subscriptions. We use Azure, so we have to switch between subscriptions with the az account set -n command. That is, if the current subscription is different from the backend, the code planned for the change is not applied because it can't get the state files.

@romanprog
Copy link
Contributor

It looks like an error handling bug at the unit initialization stage. I don't think that the technical reason for the initialization error matters. I will check.

@romanprog romanprog self-assigned this Aug 19, 2024
@kinseii
Copy link
Author

kinseii commented Aug 20, 2024

It looks like an error handling bug at the unit initialization stage. I don't think that the technical reason for the initialization error matters. I will check.

I can send clearer code, as an example, to reproduce the error. In general, the error occurs when I use a Kubernetes or Helm Unit with a single cluster context that is only accessible from its corresponding Azure subscription. If I switch to another subscription, it gives this Unite processing error, which is correct. However, the problem is that the final output says that apply was successful, even though it is not. This misled me until I went through the cdev output in detail.

@romanprog
Copy link
Contributor

I can send clearer code, as an example, to reproduce the error.

No need.
I found the error and fixed it. Will be in the next release. Thank you.

@romanprog
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants