Skip to content

Commit ec47090

Browse files
committed
Clean up Freenect2Replay coding style
1 parent 03e5b6f commit ec47090

File tree

2 files changed

+108
-194
lines changed

2 files changed

+108
-194
lines changed

include/libfreenect2/libfreenect2.hpp

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -275,17 +275,12 @@ class LIBFREENECT2_API Freenect2
275275
Freenect2& operator=(const Freenect2&);
276276
};
277277

278-
class Freenect2ReplayDevice;
278+
class Freenect2ReplayImpl;
279279

280280
/**
281281
* Library context to create and open replay devices.
282282
*
283-
* You openDevice() and control the device with returned Freenect2ReplayDevice object.
284-
*
285-
* You may open devices with custom PacketPipeline.
286-
* After passing a PacketPipeline object to libfreenect2 do not use or free the object,
287-
* libfreenect2 will take care. If openDevice() fails the PacketPipeline object will get
288-
* deleted. A new PacketPipeline object has to be created each time a device is opened.
283+
* Call openDevice() and control the device with the returned Freenect2ReplayDevice object.
289284
*/
290285
class LIBFREENECT2_API Freenect2Replay
291286
{
@@ -296,12 +291,7 @@ class LIBFREENECT2_API Freenect2Replay
296291
Freenect2Replay();
297292
virtual ~Freenect2Replay();
298293

299-
/**
300-
* @return Replay device serial number.
301-
*/
302-
std::string getDefaultDeviceSerialNumber();
303-
304-
/** Open device by a collection of stored frame filenames with default pipeline.
294+
/** Open a device by a collection of stored frame filenames with default pipeline.
305295
* See filename format below.
306296
* @param frame_filenames A list of filenames for stored frames.
307297
* @return New device object, or NULL on failure
@@ -314,24 +304,16 @@ class LIBFREENECT2_API Freenect2Replay
314304
* <prefix> - a string of the filename, anything
315305
* <timestamp> -- packet timestamp as in pipeline packets
316306
* <sequence> -- frame sequence number in the packet
317-
* <suffix> -- .depth, .jpg, or .jpeg (case insensitive)
307+
* <suffix> -- .depth, .jpg, or .jpeg (case sensitive)
318308
* @param frame_filenames A list of filenames for stored frames.
319309
* @param factory New PacketPipeline instance. This is always automatically freed.
320310
* @return New device object, or NULL on failure
321311
*/
322312
Freenect2Device *openDevice(const std::vector<std::string>& frame_filenames, const PacketPipeline *factory);
323313

324314
private:
325-
typedef std::vector<Freenect2ReplayDevice*> DeviceVector;
326-
DeviceVector devices_;
327-
328-
bool initialized;
315+
Freenect2ReplayImpl *impl_;
329316

330-
void addDevice(Freenect2ReplayDevice *device);
331-
void removeDevice(Freenect2ReplayDevice *device);
332-
void clearDevices();
333-
int getNumDevices();
334-
335317
/* Disable copy and assignment constructors */
336318
Freenect2Replay(const Freenect2Replay&);
337319
Freenect2Replay& operator=(const Freenect2Replay&);

0 commit comments

Comments
 (0)