Fix bug with removing multiple dependencies (#25)

Author: stekovinbranturry

source/add-remove-dependencies.js

@@ -37,8 +37,10 @@ export async function removePackageDependencies(filePath, dependencies, options)
 			delete pkg.dependencies[dependency];
 		}
 	} else {
-		for (const [dependencyKey, dependency] of Object.entries(dependencies)) {
-			delete pkg[dependencyKey][dependency];
+		for (const [dependencyKey, _dependencies] of Object.entries(dependencies)) {
+			for (const dependency of _dependencies) {
+				delete pkg[dependencyKey][dependency];
+			}
 		}
 	}
 
@@ -70,8 +72,10 @@ export function removePackageDependenciesSync(filePath, dependencies, options) {
 			delete pkg.dependencies[dependency];
 		}
 	} else {
-		for (const [dependencyKey, dependency] of Object.entries(dependencies)) {
-			delete pkg[dependencyKey][dependency];
+		for (const [dependencyKey, _dependencies] of Object.entries(dependencies)) {
+			for (const dependency of _dependencies) {
+				delete pkg[dependencyKey][dependency];
+			}
 		}
 	}
 

test/remove-dependencies.js

@@ -1,7 +1,7 @@
 import path from 'node:path';
 import fs, {promises as fsPromises} from 'node:fs';
 import test from 'ava';
-import {omit} from 'filter-anything';
+import {omit, pick} from 'filter-anything';
 import {temporaryDirectory} from 'tempy';
 import {readPackage, readPackageSync} from 'read-pkg';
 import {removePackageDependencies, removePackageDependenciesSync, writePackage, writePackageSync} from '../index.js';
@@ -49,6 +49,23 @@ test('async - multiple types', async t => {
 	t.deepEqual(packageJson, omit(fixture, ['dependencies', 'devDependencies.bar']));
 });
 
+test('async - multiple types with multiple dependencies', async t => {
+	const temporary = temporaryDirectory();
+
+	const fixture = {
+		name: 'foo',
+		dependencies: {foo: '1.0.0', bar: '1.0.0', baz: '1.0.0'},
+		devDependencies: {foobar: '1.0.0', foobaz: '1.0.0'},
+	};
+
+	await writePackage(temporary, fixture);
+
+	await removePackageDependencies(temporary, {dependencies: ['foo', 'bar'], devDependencies: ['foobar', 'foobaz']});
+	const packageJson = await readPackage({cwd: temporary, normalize: false});
+
+	t.deepEqual(packageJson, pick(fixture, ['name', 'dependencies.baz']));
+});
+
 test('async - should not throw if package.json does not exist', async t => {
 	const temporary = temporaryDirectory();
 	await t.notThrowsAsync(removePackageDependencies(temporary, ['foo']));
@@ -152,6 +169,23 @@ test('sync - multiple types', t => {
 	t.deepEqual(packageJson, omit(fixture, ['dependencies', 'devDependencies.bar']));
 });
 
+test('sync - multiple types with multiple dependencies', t => {
+	const temporary = temporaryDirectory();
+
+	const fixture = {
+		name: 'foo',
+		dependencies: {foo: '1.0.0', bar: '1.0.0', baz: '1.0.0'},
+		devDependencies: {foobar: '1.0.0', foobaz: '1.0.0'},
+	};
+
+	writePackageSync(temporary, fixture);
+
+	removePackageDependenciesSync(temporary, {dependencies: ['foo', 'bar'], devDependencies: ['foobar', 'foobaz']});
+	const packageJson = readPackageSync({cwd: temporary, normalize: false});
+
+	t.deepEqual(packageJson, pick(fixture, ['name', 'dependencies.baz']));
+});
+
 test('sync - should not throw if package.json does not exist', t => {
 	const temporary = temporaryDirectory();
 	t.notThrows(() => removePackageDependenciesSync(temporary, ['foo']));