Merge pull request SRombauts#139 from fekir/clean_destructors

Remove unnecessary noexcept identifier from destructors

Author: SRombauts

include/SQLiteCpp/Backup.h

@@ -100,7 +100,7 @@ class Backup
            Database& aSrcDatabase);
 
     /// Release the SQLite Backup resource.
-    virtual ~Backup() noexcept;
+    virtual ~Backup();
 
     /**
      * @brief Execute a step of backup with a given number of source pages to be copied

include/SQLiteCpp/Column.h

@@ -54,7 +54,7 @@ class Column
      */
     Column(Statement::Ptr& aStmtPtr, int aIndex)    noexcept; // nothrow
     /// Simple destructor
-    virtual ~Column()                               noexcept; // nothrow
+    virtual ~Column();
 
     // default copy constructor and assignment operator are perfectly suited :
     // they copy the Statement::Ptr which in turn increments the reference counter.

include/SQLiteCpp/Database.h

@@ -127,7 +127,7 @@ class Database
      *
      * @warning assert in case of error
      */
-    virtual ~Database() noexcept; // nothrow
+    virtual ~Database();
 
     /**
      * @brief Set a busy handler that sleeps for a specified amount of time when a table is locked.

include/SQLiteCpp/Statement.h

@@ -73,7 +73,7 @@ class Statement
     Statement(Database& aDatabase, const std::string& aQuery);
 
     /// Finalize and unregister the SQL query from the SQLite Database Connection.
-    virtual ~Statement() noexcept; // nothrow
+    virtual ~Statement();
 
     /// Reset the statement to make it ready for a new execution.
     void reset();
@@ -564,7 +564,7 @@ class Statement
         // Copy constructor increments the ref counter
         Ptr(const Ptr& aPtr);
         // Decrement the ref counter and finalize the sqlite3_stmt when it reaches 0
-        ~Ptr() noexcept; // nothrow (no virtual destructor needed here)
+        ~Ptr();
 
         /// Inline cast operator returning the pointer to SQLite Database Connection Handle
         inline operator sqlite3*() const

include/SQLiteCpp/Transaction.h

@@ -55,7 +55,7 @@ class Transaction
     /**
      * @brief Safely rollback the transaction if it has not been committed.
      */
-    virtual ~Transaction() noexcept; // nothrow
+    virtual ~Transaction();
 
     /**
      * @brief Commit the transaction.

src/Backup.cpp

@@ -70,7 +70,7 @@ Backup::Backup(Database &aDestDatabase, Database &aSrcDatabase) :
 }
 
 // Release resource for SQLite database backup
-Backup::~Backup() noexcept
+Backup::~Backup()
 {
     if (NULL != mpSQLiteBackup)
     {

src/Column.cpp

@@ -33,7 +33,7 @@ Column::Column(Statement::Ptr& aStmtPtr, int aIndex) noexcept : // nothrow
 }
 
 // Finalize and unregister the SQL query from the SQLite Database Connection.
-Column::~Column() noexcept // nothrow
+Column::~Column()
 {
     // the finalization will be done by the destructor of the last shared pointer
 }

src/Database.cpp

@@ -92,7 +92,7 @@ Database::Database(const std::string& aFilename,
 }
 
 // Close the SQLite database connection.
-Database::~Database() noexcept // nothrow
+Database::~Database()
 {
     const int ret = sqlite3_close(mpSQLite);
 

src/Statement.cpp

@@ -44,7 +44,7 @@ Statement::Statement(Database &aDatabase, const std::string& aQuery) :
 
 
 // Finalize and unregister the SQL query from the SQLite Database Connection.
-Statement::~Statement() noexcept // nothrow
+Statement::~Statement()
 {
     // the finalization will be done by the destructor of the last shared pointer
 }
@@ -437,7 +437,7 @@ Statement::Ptr::Ptr(const Statement::Ptr& aPtr) :
 /**
  * @brief Decrement the ref counter and finalize the sqlite3_stmt when it reaches 0
  */
-Statement::Ptr::~Ptr() noexcept // nothrow
+Statement::Ptr::~Ptr()
 {
     assert(NULL != mpRefCount);
     assert(0 != *mpRefCount);

src/Transaction.cpp

@@ -27,7 +27,7 @@ Transaction::Transaction(Database& aDatabase) :
 }
 
 // Safely rollback the transaction if it has not been committed.
-Transaction::~Transaction() noexcept // nothrow
+Transaction::~Transaction()
 {
     if (false == mbCommited)
     {