Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: socketio/socket.io-client-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.x
Choose a head ref
  • 7 commits
  • 16 files changed
  • 1 contributor

Commits on Jul 10, 2022

  1. fix: fix usage with ws:// scheme 

    The URL constructor does not support the ws:// scheme, and would throw:

> java.net.MalformedURLException: unknown protocol: ws

Related:

- #650
- #555
- #233

Backported from 67fd5f3
    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    e57160a View commit details
    Browse the repository at this point in the history

  2. fix: ensure buffered events are sent in order 

    Before this commit, an event sent in the "connect" handler could be
sent before the events that were buffered while disconnected.

Related: socketio/socket.io-client#1458

Backported from 4885e7d
    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    8bd35da View commit details
    Browse the repository at this point in the history

  3. fix: ensure the payload format is valid 

    This commit should prevent some NPE issues encountered after the
parsing of the packet.

Related:

- #642
- #609
- #505

Backported from e8ffe9d
    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    8664499 View commit details
    Browse the repository at this point in the history

  4. fix: ensure randomizationFactor is always between 0 and 1 

    Using a randomizationFactor value above 1 could lead to generating a
negative duration, then throwing:

> java.lang.IllegalArgumentException: delay < 0: -1012
> at java.util.Timer.schedule(Timer.java:454)
> at io.socket.client.Manager.reconnect(Manager.java:544)

This error does not seem related to a long overflow (in the
BigInteger.longValue() operation), because the BigInteger.min(this.max)
operation before should prevent it.

Related: #349

Backported from 0cbf01e
    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    cb966d5 View commit details
    Browse the repository at this point in the history

  5. chore: bump engine.io-client to version 1.0.2 

    Diff: socketio/engine.io-client-java@engine.io-client-1.0.1...engine.io-client-1.0.2
Release notes: https://github.com/socketio/engine.io-client-java/releases/tag/engine.io-client-1.0.2
    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    728690f View commit details
    Browse the repository at this point in the history

  6. chore(release): prepare release socket.io-client-1.0.2

    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    812980d View commit details
    Browse the repository at this point in the history

  7. chore(release): prepare for next development iteration

    @darrachequesne
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    b113f7b View commit details
    Browse the repository at this point in the history
Loading