Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client-swift
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: socketio/socket.io-client-swift
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0-swift4
Choose a head ref
  • 8 commits
  • 11 files changed
  • 3 contributors

Commits on Jan 5, 2018

  1. Migrated the Socket.IO 1.X build to Swift 4

    @shanecowherd
    shanecowherd committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    46d982d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Updated Project Swift variable to 4.0 

    Fixed handleOpen(openData) bug that was not covered in the unit tests.
    @shanecowherd
    shanecowherd committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    d3aaaec View commit details
    Browse the repository at this point in the history

  2. Merge pull request #925 from bombbomb/feature/9.0.1/Swift4 

    Feature/9.0.1/swift4
    @nuclearace
    nuclearace authored Jan 8, 2018
    Configuration menu
    Copy the full SHA
    424ab6c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Convert to Swift 4.2

    Dmitry Preobrazhenskiy committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    4ca2710 View commit details
    Browse the repository at this point in the history

  2. Fix failing tests 

    This is achieved by adding sorted keys with iOS 11 to the JSONSerialization
which should produce the outcome string sorted
    Dmitry Preobrazhenskiy committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    add7a83 View commit details
    Browse the repository at this point in the history

  3. fixup! Fix failing tests

    Dmitry Preobrazhenskiy committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    c0a4273 View commit details
    Browse the repository at this point in the history

  4. Update podspec 

    Remove the swift version and update podspec to include Swift 4.2

Fixes #1101
    Dmitry Preobrazhenskiy committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    4af28c3 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1123 from DmitryPR/socket-1.0 

    Convert to Swift 4.2
    @nuclearace
    nuclearace authored Nov 28, 2018
    Configuration menu
    Copy the full SHA
    9b44bfb View commit details
    Browse the repository at this point in the history
Loading