-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Comparing changes
Open a pull request
base repository: socketio/socket.io
base: 2.3.0
head repository: socketio/socket.io
compare: 2.5.0
- 13 commits
- 11 files changed
- 2 contributors
Commits on Jan 4, 2021
-
Due to the recent changes to the Travis CI platform (see [1]), we will now use GitHub Actions to run the tests. Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
Configuration menu - View commit details
-
Copy full SHA for 6fa026f - Browse repository at this point
Copy the full SHA 6fa026fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3951a79 - Browse repository at this point
Copy the full SHA 3951a79View commit details -
fix: properly overwrite the query sent in the handshake
The `query` option of the Manager had the priority over the one of the Socket instance, which meant updating the Socket#query object on the client-side was not reflected in the Socket#handshake object on the server-side. Please note that the behavior of the `query` option is still a bit weird in Socket.IO v2, as it only applies to non-default namespace. This is fixed in v3: - https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#Add-a-clear-distinction-between-the-Manager-query-option-and-the-Socket-query-option - https://socket.io/docs/v3/middlewares/#Sending-credentials Fixes #3495
Configuration menu - View commit details
-
Copy full SHA for d33a619 - Browse repository at this point
Copy the full SHA d33a619View commit details -
fix(security): do not allow all origins by default
BREAKING CHANGE: previously, all origins were allowed by default, which meant that a Socket.IO server sent the necessary CORS headers (`Access-Control-Allow-xxx`) to any domain by default. Please note that you are not impacted if: - you are using Socket.IO v2 and the `origins` option to restrict the list of allowed domains - you are using Socket.IO v3 (disabled by default) This commit also removes the support for '*' matchers and protocol-less URL: ``` io.origins('https://example.com:443'); => io.origins(['https://example.com']); io.origins('localhost:3000'); => io.origins(['http://localhost:3000']); io.origins('http://localhost:*'); => io.origins(['http://localhost:3000']); io.origins('*:3000'); => io.origins(['http://localhost:3000']); ``` To restore the previous behavior (please use with caution): ```js io.origins((_, callback) => { callback(null, true); }); ``` See also: - https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS - https://socket.io/docs/v3/handling-cors/ - https://socket.io/docs/v3/migrating-from-2-x-to-3-0/#CORS-handling Thanks a lot to https://github.com/ni8walk3r for the security report.
1Configuration menu - View commit details
-
Copy full SHA for f78a575 - Browse repository at this point
Copy the full SHA f78a575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 873fdc5 - Browse repository at this point
Copy the full SHA 873fdc5View commit details
Commits on Jan 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a169050 - Browse repository at this point
Copy the full SHA a169050View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b8697 - Browse repository at this point
Copy the full SHA e6b8697View commit details
Commits on Jun 26, 2022
-
chore: update engine.io version to 3.6.0
Release notes: https://github.com/socketio/engine.io/releases/tag/3.6.0 Diff: socketio/engine.io@3.5.0...3.6.0
Configuration menu - View commit details
-
Copy full SHA for dfded53 - Browse repository at this point
Copy the full SHA dfded53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22d4bdf - Browse repository at this point
Copy the full SHA 22d4bdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05e1278 - Browse repository at this point
Copy the full SHA 05e1278View commit details -
fix: only set 'connected' to true after middleware execution
The Socket instance is only considered connected when the "connection" event is emitted, and not during the middleware(s) execution. ```js io.use((socket, next) => { console.log(socket.connected); // prints "false" next(); }); io.on("connection", (socket) => { console.log(socket.connected); // prints "true" }); ``` Related: #4129 Backported from 02b0f73
Configuration menu - View commit details
-
Copy full SHA for 226cc16 - Browse repository at this point
Copy the full SHA 226cc16View commit details -
fix: prevent the socket from joining a room after disconnection
Configuration menu - View commit details
-
Copy full SHA for f223178 - Browse repository at this point
Copy the full SHA f223178View commit details -
Release notes: https://github.com/socketio/socket.io/releases/tag/2.5.0 Diff: 2.4.1...2.5.0
Configuration menu - View commit details
-
Copy full SHA for baa6804 - Browse repository at this point
Copy the full SHA baa6804View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.3.0...2.5.0