Skip to content

[Search] Missing results for query "ParentProps" #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awhitford opened this issue Feb 22, 2025 · 3 comments
Open

[Search] Missing results for query "ParentProps" #1091

awhitford opened this issue Feb 22, 2025 · 3 comments
Labels
help wanted Looking for assistance on this issue solid Related to core Solid

Comments

@awhitford
Copy link

Shouldn't searching for ParentProps at least find this page? https://docs.solidjs.com/configuration/typescript#components-with-children

@LadyBluenotes LadyBluenotes added help wanted Looking for assistance on this issue solid Related to core Solid labels Mar 8, 2025
@LadyBluenotes
Copy link
Member

Hi @awhitford ! Sorry for taking a bit to get back to you with this.

Are you referring to just finding the type within the docs?

For what it's worth, I don't think this gets indexed in a way that's ideal for this, and I'm not sure we can explicitly address this with the search function. I believe it may be time to introduce something that lists out all the types, or at the very least get a better with documenting them within the reference section. Do you feel like that would better solve what you were facing at the time?

@awhitford
Copy link
Author

I think my point was that the fancy Orama search wasn't being effective when it can't connect a search term like ParentProps to a page like https://docs.solidjs.com/configuration/typescript#components-with-children which is a page clearly mentioning the term. I suspect that this is worth raising to the Orama team as their is likely some kind of configuration adjustment necessary.

@LadyBluenotes
Copy link
Member

@awhitford will do, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for assistance on this issue solid Related to core Solid
Projects
None yet
Development

No branches or pull requests

2 participants