style(clang-tidy): fix modernize-avoid-c-arrays (#1814)

Signed-off-by: Balakrishna Avulapati <[email protected]>

Author: bavulapati

src/core/gzip/gzip.cc

@@ -4,6 +4,7 @@ extern "C" {
 #include <zlib.h>
 }
 
+#include <array>   // std::array
 #include <cstring> // std::memset
 #include <sstream> // std::ostringstream
 
@@ -21,14 +22,14 @@ auto gzip(std::string_view input) -> std::optional<std::string> {
   stream.next_in = reinterpret_cast<Bytef *>(const_cast<char *>(input.data()));
   stream.avail_in = static_cast<uInt>(input.size());
 
-  char buffer[4096];
+  std::array<char, 4096> buffer;
   std::ostringstream compressed;
 
   do {
-    stream.next_out = reinterpret_cast<Bytef *>(buffer);
+    stream.next_out = reinterpret_cast<Bytef *>(buffer.data());
     stream.avail_out = sizeof(buffer);
     code = deflate(&stream, Z_FINISH);
-    compressed.write(buffer, sizeof(buffer) - stream.avail_out);
+    compressed.write(buffer.data(), sizeof(buffer) - stream.avail_out);
   } while (code == Z_OK);
 
   if (code != Z_STREAM_END) {

src/core/md5/md5.cc

@@ -1,5 +1,6 @@
 #include <sourcemeta/core/md5.h>
 
+#include <array>   // std::array
 #include <iomanip> // std::setfill, std::setw
 #include <ios>     // std::hex
 
@@ -29,9 +30,10 @@ auto md5(std::string_view input, std::ostream &output) -> void {
   br_md5_context context;
   br_md5_init(&context);
   br_md5_update(&context, input.data(), input.size());
-  unsigned char hash[br_md5_SIZE];
-  br_md5_out(&context, hash);
-  std::string_view buffer{reinterpret_cast<const char *>(hash), br_md5_SIZE};
+  std::array<unsigned char, br_md5_SIZE> hash;
+  br_md5_out(&context, hash.data());
+  std::string_view buffer{reinterpret_cast<const char *>(hash.data()),
+                          br_md5_SIZE};
   output << std::hex << std::setfill('0');
   for (const auto character : buffer) {
     output << std::setw(2)

src/core/uri/escaping.cc

@@ -3,6 +3,7 @@
 #include <sourcemeta/core/uri_escape.h>
 
 #include <algorithm> // std::copy
+#include <array>     // std::array
 #include <cassert>   // assert
 #include <cctype>    // std::isalnum
 #include <istream>   // std::istream
@@ -14,7 +15,8 @@ namespace sourcemeta::core {
 
 auto uri_escape(const char character, std::ostream &output,
                 const URIEscapeMode mode) -> void {
-  constexpr char HEX[] = "0123456789ABCDEF";
+  const std::array<char, 16> HEX = {{'0', '1', '2', '3', '4', '5', '6', '7',
+                                     '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'}};
 
   // unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~"
   // See https://www.rfc-editor.org/rfc/rfc3986#appendix-A