Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: spf13/cobra
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.9.0
Choose a base ref
...
head repository: spf13/cobra
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.9.1
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Feb 16, 2025

  1. fix CompletionFunc implementation (#2234) 

    The new type CompletionFunc could lead to a regression.
This commit make the new `CompletionFunc` type a type alias instead,
in case projects using Cobra have created their own similar type.

This commit also adds a test to ensure that the completion function
remains backwards-compatible.

Signed-off-by: ccoVeille <[email protected]>
    @ccoVeille
    ccoVeille authored Feb 16, 2025
    Configuration menu
    Copy the full SHA
    a97f9fd View commit details
    Browse the repository at this point in the history

  2. Revert "Make detection for test-binary more universal (#2173)" (#2235) 

    This reverts commit d1e9d85.

Some programs set os.Args in their unit tests and this change would
break those tests.

Ref: #2173 (comment)
    @marckhouzam
    marckhouzam authored Feb 16, 2025
    Configuration menu
    Copy the full SHA
    40b5bc1 View commit details
    Browse the repository at this point in the history
Loading