Skip to content

Classpath ordering of archives differs for executing fat jar vs exploded #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aclement opened this issue Nov 29, 2017 · 2 comments
Closed
Labels
status: duplicate A duplicate of another issue

Comments

@aclement
Copy link
Contributor

When running a fat jar the list of entries from the BOOT-INF/lib folder is treated as already ordered (as produced by the maven plugin) - so we respect it and do not modify it when constructing the classpath we'll use. When running as an exploded jar, we walk the file system and alphabetically sort the set of archives we find in the BOOT-INF/lib folder. This could give rise to unexpected issues, particularly if you run the jar locally and it is fine then push it to cloud foundry, where it will be unpacked prior to launch. It is important that the order is predictable but it would be even better if the order was also the same in both cases.

Discussed it a bit with Phil and we talked about perhaps a manifest of the ordering being placed in the jar which could then be discovered in the exploded case and used to order the jars we find. (Is this a bit like the thin jar manifest...)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 29, 2017
@spencergibb
Copy link
Member

I worked with a user on this before as well since auto-configuration changed because of the ordering. Actually, I think the user was @mminella.

@wilkinsona
Copy link
Member

Duplicate of #9128.

@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants