Skip to content

Review SSL info contribution and its use of management.health.ssl.certificate-validity-warning-threshold #44650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wilkinsona opened this issue Mar 7, 2025 · 1 comment
Open

Review SSL info contribution and its use of management.health.ssl.certificate-validity-warning-threshold #44650

wilkinsona opened this issue Mar 7, 2025 · 1 comment
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: enhancement A general enhancement
Milestone
4.0.x

Comments

@wilkinsona
Copy link
Member

Having a management.health.ssl property affect SSL info doesn't feel quite right, particularly as it's management.info.ssl.enabled that's used to enable/disable the SSL info contribution. Having separate threshold properties for SSL health and SSL info also doesn't feel quite right either as I expect that you'd always want them to have the same value.
@wilkinsona wilkinsona added for: team-meeting An issue we'd like to discuss as a team to make progress status: pending-design-work Needs design work before any code can be developed labels Mar 7, 2025
@philwebb
Copy link
Member

philwebb commented May 7, 2025

We discussed this today and we think we should probably get rid of the feature in info.

@philwebb philwebb added type: enhancement A general enhancement theme: structure Issues related to the structure of the project and its code and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels May 7, 2025
@philwebb philwebb added this to the 4.0.x milestone May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: enhancement A general enhancement
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona