Skip to content

Prefer request hostName and hostPort in ReactorServerHttpRequest #30062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Prefer request hostName and hostPort in ReactorServerHttpRequest #30062

wants to merge 2 commits into from

Conversation

@violetagg
Copy link
Member

@violetagg violetagg commented Mar 2, 2023

  • Prefer request hostName and hostPort in ReactorServerHttpRequest#resolveBaseUrl
  • The request hostName and hostPort are derived from the Host/X-Forwarded-*/Forwarded header associated with this request
  • Do not add the port when it is the default one

Closes gh-30033

@violetagg
Prefer request hostName and hostPort in ReactorServerHttpRequest
af8de1f 
- Prefer request hostName and hostPort in ReactorServerHttpRequest#resolveBaseUrl
- The request hostName and hostPort are derived from the Host/X-Forwarded-*/Forwarded header associated with this request.
- Do not add the port when it is the default one

Closes spring-projectsgh-30033
@violetagg
Copy link
Member Author

violetagg commented Mar 2, 2023

@rstoyanchev PTAL

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 2, 2023
@rstoyanchev rstoyanchev self-assigned this Mar 2, 2023
@rstoyanchev rstoyanchev added this to the 6.0.6 milestone Mar 2, 2023
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 2, 2023
@violetagg
Check for ws/wss scheme
7fff0d3 
Remove unused import
rstoyanchev pushed a commit that referenced this pull request Mar 2, 2023
@violetagg @rstoyanchev
Prefer request hostName and hostPort in ReactorServerHttpRequest
682a4d5 
See gh-30062
@rstoyanchev rstoyanchev mentioned this pull request Mar 2, 2023
Closed
@poutsma poutsma mentioned this pull request Apr 5, 2023
Closed
@violetagg violetagg deleted the issue-30033 branch August 30, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rstoyanchev rstoyanchev

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Milestone

6.0.6

Development

Successfully merging this pull request may close these issues.

Server request URL with spring-webflux 6.0.5 is in resolved IP6 format

3 participants

@violetagg @rstoyanchev @spring-projects-issues