Skip to content

Conversation

@ghostg00
Copy link
Contributor

The echoWebSocketHandler method is not in the WebSocketConfigurer interface. It should be the @bean annotation

@pivotal-cla
Copy link

@ghostg00 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ghostg00 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 24, 2023
@sbrannen sbrannen self-assigned this Mar 24, 2023
@sbrannen sbrannen changed the title Fix javadoc code documentation in EnableWebSocket Fix example in Javadoc for @EnableWebSocket Mar 24, 2023
@sbrannen sbrannen added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 24, 2023
@sbrannen sbrannen added this to the 6.0.8 milestone Mar 24, 2023
@sbrannen sbrannen added for: backport-to-5.3.x status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x labels Mar 24, 2023
@sbrannen sbrannen closed this in e66c806 Mar 24, 2023
@sbrannen
Copy link
Member

Hi @ghostg00,

Good catch, and congratulations on submitting your first PR to the Spring Framework! 👍

This has been merged into main and backported to 5.3.x.

Thanks

@wuyanzu-9527
Copy link

good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: documentation A documentation task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants