Skip to content

DataFetcherResult extensions are ignored #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kravuar opened this issue May 7, 2025 · 2 comments
Closed

DataFetcherResult extensions are ignored #1201

Kravuar opened this issue May 7, 2025 · 2 comments
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged

Comments

@Kravuar
Copy link

Kravuar commented May 7, 2025

Migrated from 1.3.4 to 1.3.5
In my DataFetcher I was returning DataFetcherResult with extensions:

return DataFetcherResult.newResult()
                    .data(...)
                    .extensions(Map.of(...))
                    .build();

In 1.3.5 in org.springframework.graphql.execution.ContextDataFetcherDecorator::get method there's new piece of code, which reconstructs the DataFetcherResult, but without extensions being passed from original one. Is this a bug, or am I'm using DataFetcherResult wrong?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2025
@bclozel
Copy link
Member

bclozel commented May 7, 2025

@Kravuar I think this has been fixed already with #1199

Can you check with 1.3.6-SNAPSHOT that this is working with your application?

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label May 7, 2025
@Kravuar
Copy link
Author

Kravuar commented May 7, 2025

Oh, missed the existing issue somehow. Yes, problem is gone, thanks

@Kravuar Kravuar closed this as completed May 7, 2025
@bclozel bclozel closed this as completed May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants