Skip to content

Unknown property 'url' for type 'VaultConfig' vscode-concourse(YamlSchemaProblem) #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cluedtke opened this issue Apr 8, 2025 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: concourse-support type: bug

Comments

@cluedtke
Copy link

cluedtke commented Apr 8, 2025

Describe the bug
concourse-language-server incorrectly defines uri, should instead be url according to the docs: https://concourse-ci.org/vars.html#schema.var_source

I know var_sources is flagged as "experimental", and uri may have been used in the past, but I've been using url without issue for the past year.

I'd be happy to raise a PR if you agree with changing uri to url.

To Reproduce
Define a vault var_source type, with a VaultConfig that includes the correct field, url. This gives an error:

Unknown property 'url' for type 'VaultConfig'vscode-concourse' (YamlSchemaProblem)

Sample

var_sources:
  - name: vault-aws-engine-account
    type: vault
    config:
      url: https://my-vault-server.io
      path_prefix: aws
      auth_backend: approle
      auth_params:
        role_id: concourse-access-role_id
        secret_id: concourse-access-secret_id
@martinlippert martinlippert added for: eclipse something that is specific for Eclipse theme: concourse-support for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Apr 8, 2025
@martinlippert martinlippert added this to the 4.30.0.RELEASE milestone Apr 8, 2025
@BoykoAlex
Copy link
Contributor

Fixed via deab69a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: concourse-support type: bug
Projects
None yet
Development

No branches or pull requests

3 participants