Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Commit 293e70f

Browse files
committed
Don't assign err from ForEach loop
Since we don't check the value anyway, as it can't possibly be anything but nil. Signed-off-by: Christian Muehlhaeuser <[email protected]>
1 parent c363771 commit 293e70f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

plumbing/object/merge_base.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func (c *Commit) MergeBase(other *Commit) ([]*Commit, error) {
3232
var res []*Commit
3333
inNewerHistory := isInIndexCommitFilter(newerHistory)
3434
resIter := NewFilterCommitIter(older, &inNewerHistory, &inNewerHistory)
35-
err = resIter.ForEach(func(commit *Commit) error {
35+
_ = resIter.ForEach(func(commit *Commit) error {
3636
res = append(res, commit)
3737
return nil
3838
})

0 commit comments

Comments
 (0)