Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stelligent/mu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.2
Choose a base ref
...
head repository: stelligent/mu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.5.3
Choose a head ref
  • 13 commits
  • 18 files changed
  • 3 contributors

Commits on Aug 30, 2018

  1. bump version

    cplee committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    da521d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Issue #258 - Add validate command and strict unmarshalling

    Required an update to the yaml package in order to use
    unmarshalStrict.
    
    Validate method currently runs and returns null. Based on the
    issue description it seemed appropriate to always do a strict
    check on the config and let the errors thrown there take care
    of actual validation. The validate command is really just
    a null method that loads the config like normal to perform
    checks.
    mneil committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    3ccfc33 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Issue #258 - Added validator and started validation of config

    Ran into a few pitfalls and things to note:
    
     - Yaml is already coercing values so no need to validate "types"
       - int, string, bool
     - Regex seekms to require ^ and $ to denote string - might be go specific?
     - Keep validate command an empty stub and just exit the "Before" func
       - Doing anything else complicates the code with no advantages
       - Gains all validation entrypoints in 1 place
    mneil committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    942b338 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Issue #258 - Adding more validation rules

    Making a lot of assumptions about validation rules for
    structs.
    
     - Validator is using MathString hence requires ^$
     - Using types for contraints on lists of items is easier
     - Some validation is still loose
       - Validating an AMI just checks for ami-[0-9a-z]+
       - No good constraints on instance types - a list would be great
    
    Trying to balance flexibility with usefulness. Contraining
    to all current instance types that are valid would require
    keeping mu up to date to support new instances - which seems
    not helpful.
    mneil committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    339f0c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. Issue #258 - Move constraints to custom methods and add tests

    There were a lot of similarities between the regular expressions
    I was writing and I honestly didn't like having regexp all over
    types.go. The custom method names are more descriptive of what
    the validation is actually doing and it means I can probably
    just test these custom methods instead of writing tests for
    each and every property of the types.
    
    I already have tests for a lot of properties so I'm not going
    to remove them. Going forward though I will only write tests
    for the validation methods.
    mneil committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    ed97acd View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. Issue #258 - Added remaining validation tags and new types

    Added validation tags to the remaining struct properties. Also
    added a few new types to validate properties that have limited
    allowed values.
    mneil committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    4707724 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    00b3354 View commit details
    Browse the repository at this point in the history
  3. Issue #258 - Update ValidateURL to allow / as valid URL

    HealthEndpoint failing check in basic config because URLs could
    not start with a / and required at least 2 characters. Requirement
    loosend to allow alphanumeric and / for first character and to
    only be a single character in length.
    mneil committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    cbd1332 View commit details
    Browse the repository at this point in the history
  4. Issues #258 - Stubbed validateDockerImage

    Was validating pipeline environment image as an AMI when it
    is actually a docker image. The registry/image:tag regex
    is fairly complicated and varies between v1 and v2
    of the registries. For now just adding an empty method where
    validation may occur later if we want.
    mneil committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    9da9534 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. Merge pull request #325 from stelligent/issue-258

    Issue 258 - Validation
    
    fix #258
    cplee authored Sep 11, 2018
    Configuration menu
    Copy the full SHA
    584e0ce View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. fix #327

    cplee committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    eea7abe View commit details
    Browse the repository at this point in the history
  2. fix #327 for realz

    cplee committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f4538d0 View commit details
    Browse the repository at this point in the history
  3. update CHANGELOG for v1.5.3

    cplee committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    a7dfedc View commit details
    Browse the repository at this point in the history
Loading