-
Notifications
You must be signed in to change notification settings - Fork 132
Comparing changes
Open a pull request
base repository: stelligent/mu
base: v1.5.2
head repository: stelligent/mu
compare: v1.5.3
- 13 commits
- 18 files changed
- 3 contributors
Commits on Aug 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for da521d3 - Browse repository at this point
Copy the full SHA da521d3View commit details
Commits on Aug 31, 2018
-
Issue #258 - Add validate command and strict unmarshalling
Required an update to the yaml package in order to use unmarshalStrict. Validate method currently runs and returns null. Based on the issue description it seemed appropriate to always do a strict check on the config and let the errors thrown there take care of actual validation. The validate command is really just a null method that loads the config like normal to perform checks.
Configuration menu - View commit details
-
Copy full SHA for 3ccfc33 - Browse repository at this point
Copy the full SHA 3ccfc33View commit details
Commits on Sep 4, 2018
-
Issue #258 - Added validator and started validation of config
Ran into a few pitfalls and things to note: - Yaml is already coercing values so no need to validate "types" - int, string, bool - Regex seekms to require ^ and $ to denote string - might be go specific? - Keep validate command an empty stub and just exit the "Before" func - Doing anything else complicates the code with no advantages - Gains all validation entrypoints in 1 place
Configuration menu - View commit details
-
Copy full SHA for 942b338 - Browse repository at this point
Copy the full SHA 942b338View commit details
Commits on Sep 5, 2018
-
Issue #258 - Adding more validation rules
Making a lot of assumptions about validation rules for structs. - Validator is using MathString hence requires ^$ - Using types for contraints on lists of items is easier - Some validation is still loose - Validating an AMI just checks for ami-[0-9a-z]+ - No good constraints on instance types - a list would be great Trying to balance flexibility with usefulness. Contraining to all current instance types that are valid would require keeping mu up to date to support new instances - which seems not helpful.
Configuration menu - View commit details
-
Copy full SHA for 339f0c2 - Browse repository at this point
Copy the full SHA 339f0c2View commit details
Commits on Sep 8, 2018
-
Issue #258 - Move constraints to custom methods and add tests
There were a lot of similarities between the regular expressions I was writing and I honestly didn't like having regexp all over types.go. The custom method names are more descriptive of what the validation is actually doing and it means I can probably just test these custom methods instead of writing tests for each and every property of the types. I already have tests for a lot of properties so I'm not going to remove them. Going forward though I will only write tests for the validation methods.
Configuration menu - View commit details
-
Copy full SHA for ed97acd - Browse repository at this point
Copy the full SHA ed97acdView commit details
Commits on Sep 10, 2018
-
Issue #258 - Added remaining validation tags and new types
Added validation tags to the remaining struct properties. Also added a few new types to validate properties that have limited allowed values.
Configuration menu - View commit details
-
Copy full SHA for 4707724 - Browse repository at this point
Copy the full SHA 4707724View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00b3354 - Browse repository at this point
Copy the full SHA 00b3354View commit details -
Issue #258 - Update ValidateURL to allow / as valid URL
HealthEndpoint failing check in basic config because URLs could not start with a / and required at least 2 characters. Requirement loosend to allow alphanumeric and / for first character and to only be a single character in length.
Configuration menu - View commit details
-
Copy full SHA for cbd1332 - Browse repository at this point
Copy the full SHA cbd1332View commit details -
Issues #258 - Stubbed validateDockerImage
Was validating pipeline environment image as an AMI when it is actually a docker image. The registry/image:tag regex is fairly complicated and varies between v1 and v2 of the registries. For now just adding an empty method where validation may occur later if we want.
Configuration menu - View commit details
-
Copy full SHA for 9da9534 - Browse repository at this point
Copy the full SHA 9da9534View commit details
Commits on Sep 11, 2018
-
Merge pull request #325 from stelligent/issue-258
Issue 258 - Validation fix #258
Configuration menu - View commit details
-
Copy full SHA for 584e0ce - Browse repository at this point
Copy the full SHA 584e0ceView commit details
Commits on Sep 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for eea7abe - Browse repository at this point
Copy the full SHA eea7abeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4538d0 - Browse repository at this point
Copy the full SHA f4538d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7dfedc - Browse repository at this point
Copy the full SHA a7dfedcView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.5.2...v1.5.3