fix: added ReasonCode to trade allowances; updated tests #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanstapel
approved these changes
Jan 11, 2025
tobitege
added a commit
to tobitege/ZUGFeRD-csharp
that referenced
this pull request
Jan 13, 2025
stephanstapel
added a commit
that referenced
this pull request
Jan 13, 2025
Fix null handling in EnumExtensions (followup to #575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReasonCodetoTradeAllowanceChargeand all invoice readers/writersAllowanceReasonCodes.cs(tbd if I missed any codes). Note: the actual value being used in files is in the description.Maybe there're nicer ways to do this with mixed numeric and literal codes?