fix: Update bundle tests to have proper example (#400)

Author: zeisss

cmd/testcase_build_test.go

@@ -23,7 +23,7 @@ func TestTestcaseBuild(t *testing.T) {
 func TestTestcaseBuild__DefineParam(t *testing.T) {
 	var expectedOutput = GivenTestdataContents(t, t.Name()+"_output.js")
 	defines := map[string]string{
-		"ENV": "\"production\"", // DOUBLE QUOTING!
+		"defines.target": "\"http://example.com\"", // DOUBLE QUOTING!
 	}
 
 	var output strings.Builder

cmd/testdata/TestTestcaseBuild__DefineParam_main.mjs

@@ -1,5 +1,7 @@
+defines = {}
 const config = {
-  env: ENV || "staging",
+  target: defines.target || "http://testapp.loadtest.party"
 }
 
-definition.addTarget(env);
+definition.setArrivalPhases([{duration: 60, rate: 0,}]);
+definition.addTarget(config.target);

cmd/testdata/TestTestcaseBuild__DefineParam_output.js

@@ -1,2 +1,7 @@
 // testdata/TestTestcaseBuild__DefineParam_main.mjs
-definition.addTarget(env);
+defines = {};
+var config = {
+  target: "http://example.com"
+};
+definition.setArrivalPhases([{ duration: 60, rate: 0 }]);
+definition.addTarget(config.target);

cmd/testdata/TestTestcaseBuild__WithUndefinedVariable_main.mjs

@@ -1,5 +1,7 @@
+defines = {}
 const config = {
-  env: ENV || "staging", // Intentionally undefined in the go test
+  target: defines.target || "http://testapp.loadtest.party"
 }
 
-definition.addTarget(env);
+definition.setArrivalPhases([{duration: 60, rate: 0,}]);
+definition.addTarget(config.target);

cmd/testdata/TestTestcaseBuild__WithUndefinedVariable_output.js

@@ -1,6 +1,7 @@
 // testdata/TestTestcaseBuild__WithUndefinedVariable_main.mjs
+defines = {};
 var config = {
-  env: ENV || "staging"
-  // Intentionally undefined in the go test
+  target: defines.target || "http://testapp.loadtest.party"
 };
-definition.addTarget(env);
+definition.setArrivalPhases([{ duration: 60, rate: 0 }]);
+definition.addTarget(config.target);

testdata/cases/index.mjs

@@ -1,10 +1,13 @@
 import "./modules/options.js"
 import scenario from "./modules/scenario.js"
 
-// TODO do we want a "convention" here? An object
-// that can be used to replace value into, would be a start…
-const config = {
-  env: ENV || "staging",
+// NOTE: `--define` works on global identifiers only! To make `defines` a global identifier, it MUST NOT be defined via `var`/`let`/`const`.
+// To replace fields of `defines`, use '--define defines.env="prod"'
+defines = {};
+var config = {
+  env: defines.env || "staging",
+  target: defines.target || "https://testapp.loadtest.party",
 }
 
-definition.session("hello", scenario(config))
+definition.addTarget(config.target)
+definition.session("hello", scenario(config.env))

testdata/cases/modules/options.js

@@ -1,5 +1,3 @@
-definition.addTarget("testapp.loadtest.party")
-
 definition.setArrivalPhases([{
     duration: 60,
     rate: 42,