Skip to content

fix: remove jwt key validation to allow new api keys #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Jun 20, 2025

What kind of change does this PR introduce?

Close #1150

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@grdsdev grdsdev requested a review from silentworks June 20, 2025 17:12
@coveralls
Copy link

coveralls commented Jun 20, 2025

Pull Request Test Coverage Report for Build 15784602486

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 85.316%

Files with Coverage Reduction New Missed Lines %
supabase/_sync/client.py 5 90.08%
Totals Coverage Status
Change from base Build 15766744115: -0.9%
Covered Lines: 337
Relevant Lines: 395

💛 - Coveralls

@grdsdev grdsdev force-pushed the guilherme/clibs-210-supabase-py-does-not-handle-the-new-api-keys-secret-keys branch from 07df914 to 064326b Compare June 20, 2025 17:40
@silentworks
Copy link
Contributor

@grdsdev I'm now wondering if we should check if its not the new api key by checking for the sb_ prefix first and then still do these JWT checks otherwise?

@silentworks
Copy link
Contributor

Actually ignore my last comment. Lets remove these check all together. I just checked the JS libraries and we aren't doing such checks since the auth server will handle the validation.

@grdsdev grdsdev merged commit 70fe491 into main Jun 23, 2025
10 checks passed
@grdsdev grdsdev deleted the guilherme/clibs-210-supabase-py-does-not-handle-the-new-api-keys-secret-keys branch June 23, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supabase-py does not handle the new API keys (secret keys sb_secret_, not JWT based)
3 participants