Accessing getTargetFile() before value is assigned, Closing android-async-http#743

smarek · smarek · commit 474b36afe3b3 · 2014-11-26T09:57:46.000+01:00
diff --git a/library/src/main/java/com/loopj/android/http/FileAsyncHttpResponseHandler.java b/library/src/main/java/com/loopj/android/http/FileAsyncHttpResponseHandler.java
@@ -53,7 +53,7 @@ public FileAsyncHttpResponseHandler(File file) {
     public FileAsyncHttpResponseHandler(File file, boolean append) {
         super();
         AssertUtils.asserts(file != null, "File passed into FileAsyncHttpResponseHandler constructor must not be null");
-        AssertUtils.asserts(getTargetFile().getParentFile().mkdirs(), "Cannot create parent directories for requested File location");
+        AssertUtils.asserts(file.getParentFile().mkdirs(), "Cannot create parent directories for requested File location");
         this.mFile = file;
         this.append = append;
     }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public FileAsyncHttpResponseHandler(File file) {`
`53`	`53`	`public FileAsyncHttpResponseHandler(File file, boolean append) {`
`54`	`54`	`super();`
`55`	`55`	`AssertUtils.asserts(file != null, "File passed into FileAsyncHttpResponseHandler constructor must not be null");`
`56`		`- AssertUtils.asserts(getTargetFile().getParentFile().mkdirs(), "Cannot create parent directories for requested File location");`
	`56`	`+ AssertUtils.asserts(file.getParentFile().mkdirs(), "Cannot create parent directories for requested File location");`
`57`	`57`	`this.mFile = file;`
`58`	`58`	`this.append = append;`
`59`	`59`	`}`