-
-
Notifications
You must be signed in to change notification settings - Fork 76
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/serializer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.40
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/serializer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.41
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 7 files changed
- 4 contributors
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d920301 - Browse repository at this point
Copy the full SHA d920301View commit details
Commits on Jun 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 311006a - Browse repository at this point
Copy the full SHA 311006aView commit details
Commits on Jun 9, 2024
-
bug #52699 [Serializer] [PropertyAccessor] Ignore non-collection inte…
…rface generics (mtarld) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] [PropertyAccessor] Ignore non-collection interface generics | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #41996 #49924 | License | MIT `PhpDocExtractor` and `PhpStanDocExtractor` are following an old version of PSR-5 with used to define collections as the following: ``` generic = collection-type "<" [type-expression "," *SP] type-expression ">" ``` But, it does conflict with non-collection generics. This issue will automatically be solved if the `TypeInfo` is merged in Symfony. But for older versions (<7.1 at least), it needs a fix. ~I was not able to find a proper bug fix without introducing a BC break, so this PR proposes to opt-on the "non-collection generics" parsing, such as `stcClass<int>` for example.~ ~To opt-out from parsing these generics, it'll be required to set `ignore_docblock_generics` in the context. And this key/value will become obsolete as soon as the `TypeInfo` is introduced.~ ~I'm not sure how to proceed though, should we only merge it in 5.4, and 6.3 supposing that the `TypeInfo` might be merged in 7.x? Should we document it only in these branches?~ EDIT: I finally ignored PHPDoc generics that aren't well known collection generic types so that the process will fall back to other resolvers (such as reflection resolver for example) Commits ------- e31aeebbba [PropertyAccessor] Fix unexpected collection when generics
Configuration menu - View commit details
-
Copy full SHA for 8cdef77 - Browse repository at this point
Copy the full SHA 8cdef77View commit details
Commits on Jun 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1ffba3 - Browse repository at this point
Copy the full SHA d1ffba3View commit details -
bug #57187 [Serializer] Fix
ObjectNormalizer
with property path (Hy……peMC) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix `ObjectNormalizer` with property path | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54983 | License | MIT Caused by #52917. The `ObjectNormalizer::isAllowedAttribute()` method doesn't work with property paths, this is an attempt to fix the problem. Commits ------- 3857545d33 [Serializer] Fix `ObjectNormalizer` with property path
Configuration menu - View commit details
-
Copy full SHA for 296df0c - Browse repository at this point
Copy the full SHA 296df0cView commit details -
bug #57341 [Serializer] properly handle invalid data for false/true t…
…ypes (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] properly handle invalid data for false/true types | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony#57320 (comment) | License | MIT Commits ------- d35d4a337b properly handle invalid data for false/true types
Configuration menu - View commit details
-
Copy full SHA for 3fd3eca - Browse repository at this point
Copy the full SHA 3fd3ecaView commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c97dba5 - Browse repository at this point
Copy the full SHA c97dba5View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.4.40...v5.4.41