Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/serializer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.40
Choose a base ref
...
head repository: symfony/serializer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.41
Choose a head ref
  • 7 commits
  • 7 files changed
  • 4 contributors

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    d920301 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    311006a View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. bug #52699 [Serializer] [PropertyAccessor] Ignore non-collection inte…

    …rface generics (mtarld)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] [PropertyAccessor] Ignore non-collection interface generics
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #41996 #49924
    | License       | MIT
    
    `PhpDocExtractor` and `PhpStanDocExtractor` are following an old version of PSR-5 with used to define collections as the following:
    ```
    generic = collection-type "<" [type-expression "," *SP] type-expression ">"
    ```
    But, it does conflict with non-collection generics.
    
    This issue will automatically be solved if the `TypeInfo` is merged in Symfony. But for older versions (<7.1 at least), it needs a fix.
    
    ~I was not able to find a proper bug fix without introducing a BC break, so this PR proposes to opt-on the "non-collection generics" parsing, such as `stcClass<int>` for example.~
    
    ~To opt-out from parsing these generics, it'll be required to set `ignore_docblock_generics` in the context. And this key/value will become obsolete as soon as the `TypeInfo` is introduced.~
    
    ~I'm not sure how to proceed though, should we only merge it in 5.4, and 6.3 supposing that the `TypeInfo` might be merged in 7.x? Should we document it only in these branches?~
    
    EDIT: I finally ignored PHPDoc generics that aren't well known collection generic types so that the process will fall back to other resolvers (such as reflection resolver for example)
    
    Commits
    -------
    
    e31aeebbba [PropertyAccessor] Fix unexpected collection when generics
    fabpot committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    8cdef77 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Configuration menu
    Copy the full SHA
    d1ffba3 View commit details
    Browse the repository at this point in the history
  2. bug #57187 [Serializer] Fix ObjectNormalizer with property path (Hy…

    …peMC)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] Fix `ObjectNormalizer` with property path
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #54983
    | License       | MIT
    
    Caused by #52917.
    
    The `ObjectNormalizer::isAllowedAttribute()` method doesn't work with property paths, this is an attempt to fix the problem.
    
    Commits
    -------
    
    3857545d33 [Serializer] Fix `ObjectNormalizer` with property path
    fabpot committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    296df0c View commit details
    Browse the repository at this point in the history
  3. bug #57341 [Serializer] properly handle invalid data for false/true t…

    …ypes (xabbuh)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] properly handle invalid data for false/true types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix symfony/symfony#57320 (comment)
    | License       | MIT
    
    Commits
    -------
    
    d35d4a337b properly handle invalid data for false/true types
    xabbuh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3fd3eca View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    c97dba5 View commit details
    Browse the repository at this point in the history
Loading